Feature/dynamic list #205
Closed
Feature/dynamic list #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
发现有明显bug， 回复只能使用固定的字符串，list是伪动态，先关闭下 |
|
对序列化function感觉还比较不那么放心。求说服。 |
|
@JacksonTian 其实我也觉得序列化function这种实现很变扭，一旦序列化也就是把function变成了string，就丢失了所有的context了，目前看来也只有这么个办法。使用的这样的方法有很多的限制，算是一种曲线救国的妥协，对一个好的coder来说，能够理解为什么这么做，为什么会有限制，使用起来应该没什么太大的问题。毕竟js本身就是解释性的动态语言，Function如果抛开context的话，就是new Function('a', 'b', 'return a + b')， 也只string的拼接而已。对基础不太好的coder话，可能一下子不太能理解，但是遵守规则就好了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加了对动态List的支持，提供了serializeList和deserializeList用注册
issue: 在内部已对list进行序列化之后在返回给注册的serializer进行保存，不知道会不会产生误解