Skip to content

Conversation

xjmalm
Copy link
Contributor

@xjmalm xjmalm commented Apr 14, 2016

After getting the session from session storage, if the session.cookie.expires is string type, convert the string type to Date in case some of the session storage only stores the simple data types.

….expires is string type, convert the string type to Date in case some of the session storage only stores the simple data types
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling eb5e653 on xjmalm:master into * on node-webot:master*.

@xjmalm
Copy link
Contributor Author

xjmalm commented Apr 14, 2016

test-coveralls 的失败,和我的修改没有关系吧,我去掉了我加的代码,还是一样的失败信息。

@xjmalm
Copy link
Contributor Author

xjmalm commented Apr 14, 2016

本地加了 .coveralls.yml 文件并在里面配了我的token后,422 “Couldn't find a repository matching this job” 这个错没有了。
初次使用PR, 除了把.coveralls.yml 提交之外(这样会公开我的token),有别的办法解决这个422问题吗?

@JacksonTian
Copy link
Member

是coveralls的问题

@JacksonTian JacksonTian merged commit 50ac990 into node-webot:master Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants