Skip to content

Conversation

feifeiiiiiiiiiii
Copy link
Contributor

xml2js解析出来的对象转换成直接可访问的对象应该加上如果不是对象的情况,虽然微信的xml数据没有这种情况,个人觉得还是应该处理下比较好

@coveralls
Copy link

coveralls commented Sep 27, 2016

Coverage Status

Coverage increased (+0.01%) to 96.049% when pulling 00a3322 on feifeiiiiiiiiiii:master into 471ca31 on node-webot:master.

@JacksonTian
Copy link
Member

给个单元测试来说明这种情况?

@feifeiiiiiiiiiii
Copy link
Contributor Author

ok

@feifeiiiiiiiiiii
Copy link
Contributor Author

formatMessage这个函数对外不可可见,所以这里我只能提供一下一组样例

<xml>
   <arraytest>
       <item><![CDATA[item1]]></item>
       <item><![CDATA[item2]]></item>
   </arraytest>
</xml>

当然微信目前是没有这种类似数据的

按照没修改之前得到的结果是

{ arraytest: { item: [ {}, {} ] } }

其实正常结果应该是

{ arraytest: { item: [ 'item1', 'item2' ] } }

我说的对吧?

@JacksonTian
Copy link
Member

用rewire可以导出私有方法。

@feifeiiiiiiiiiii
Copy link
Contributor Author

ok 等我用rewire加上测试用例

@coveralls
Copy link

coveralls commented Sep 28, 2016

Coverage Status

Coverage increased (+0.9%) to 96.96% when pulling 890c36c on feifeiiiiiiiiiii:master into 471ca31 on node-webot:master.

@JacksonTian JacksonTian merged commit 613d3bc into node-webot:master Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants