Skip to content

Another Sharing Patch #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

Another Sharing Patch #1215

merged 1 commit into from
Jun 5, 2019

Conversation

jaxoncreed
Copy link
Contributor

@jaxoncreed jaxoncreed commented Jun 4, 2019 •
edited
Loading

Included in this one:

  • I feel like an idiot for forgetting subdomains AGAIN
  • This fix for Tim's static webId worked on localhost but it looks like it's not working in production 😞 so I'll fix that
  • Major security patch for ws. (Complete but not pushed to npm)
  • Guess who's back, back again. The infinite loop bug in the mother tracker's back. Tell a friend.

kjetilk
kjetilk approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though that doesn't necessarily guarantee sanity. :-)

@kjetilk kjetilk merged commit dcdcdb1 into master Jun 5, 2019
@jaxoncreed
Copy link
Contributor Author

jaxoncreed commented Jun 6, 2019 •
edited
Loading

Oh dear this shouldn't have been merged yet. I still had 2 things I needed to commit.

@kjetilk
Copy link
Member

kjetilk commented Jun 6, 2019

Uh-oh... But it didn't have WiP-tag, and it looked to me to be fairly self-contained... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjetilk kjetilk kjetilk approved these changes

@michielbdejong michielbdejong michielbdejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxoncreed @kjetilk @michielbdejong