Skip to content

Conversation

jaxoncreed
Copy link
Contributor

@michielbdejong
Copy link
Member

This PR is just about the third commit, right?

Copy link
Member

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the third commit, e35bb76.

@michielbdejong
Copy link
Member

rebased this branch so that it's just that commit on top of master. let's merge this asap even if #1241 takes longer.

@michielbdejong
Copy link
Member

tests are failing

1) Header handler
       WAC-Allow
         a resource that is read/write/append/control for the user, nothing for the public
           "before all" hook:
     Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/solid/node-solid-server/test/integration/header-test.js)

@michielbdejong
Copy link
Member

Hah, that's nice:

$ npm audit
                                                                                
                       === npm audit security report ===                        
                                                                                
found 0 vulnerabilities
 in 71944 scanned packages

@jaxoncreed jaxoncreed merged commit af9ebf0 into master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants