dev branch #1277
Merged
dev branch #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, node-solid-server no longer needs to carry its own copy of the data browser, and mashlib can include additional assets, such as stylesheets.
Annoying when I to these minor mistakes...
TallTed
reviewed
Jul 24, 2019
| <input type="text" class="form-control" name="externalWebId" id="externalWebId" value="{{externalWebId}}"/> | ||
| <span class="help-block"> | ||
| We will generate a Web ID when you register, but if you already have a Web ID hosted elsewhere that you'd prefer to use to log in, enter it here | ||
| By connecting this account with an existing webId, you can use that webId to authenticate with the new account. |
There was a problem hiding this comment.
human-facing webId or Web ID should change to always be one word, capitalized as WebID
We should have a .nvmrc file so that we consistently build with same Node version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.