Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This helps the data browser know whether or not a ACL can be deleted #1290

Closed
wants to merge 1 commit into from

Conversation

megoth
Copy link
Contributor

@megoth megoth commented Aug 19, 2019

Root ACLs should never be deleted. (#1289)

This hack is working with solid-ui to indicate whether a ACL resource is working toward the root container of a Pod. (https://github.com/solid/solid-ui/pull/96)

Root ACLs should never be deleted. (#1289)

This hack is working with solid-ui to indicate whether a ACL resource is working toward the root container of a Pod.
@michielbdejong
Copy link
Member

@megoth NSS is now EOL, so we would have to make this change in https://github.com/inrupt/wac-ldp/blob/master/src/lib/authorization/AclManager.ts#L102-L109 instead.

But apart from that, this would create an undocumented link between the databrowser (a Solid app) and the inrupt pod-server (a Solid storage server). If you think all pod servers should have this triple in their root ACL then you should add it to https://github.com/solid/specification first, and then from there it will get added to the test-suite and to the implementations. Does that make sense?

Copy link
Member

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would create a new behaviour that is not documented in the spec but that some Solid apps may start relying on.

@megoth
Copy link
Contributor Author

megoth commented Aug 19, 2019

But apart from that, this would create an undocumented link between the databrowser (a Solid app) and the inrupt pod-server (a Solid storage server). If you think all pod servers should have this triple in their root ACL then you should add it to https://github.com/solid/specification first, and then from there it will get added to the test-suite and to the implementations. Does that make sense?

I agree, it's not good to introduce hacky interim-solutions. I've added an issue to the Data Interoperability Panel that will hopefully find some standardized way of allowing this.

@megoth
Copy link
Contributor Author

megoth commented Aug 19, 2019

I'll close this PR unless someone thinks it should be added anyway, albeit being a undocumented hack.

@megoth megoth closed this Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants