Skip to content

Update dependencies #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 30, 2020
Merged

Update dependencies #163

merged 9 commits into from
Jul 30, 2020

Conversation

michielbdejong
Copy link
Member

No description provided.

@michielbdejong michielbdejong marked this pull request as draft July 24, 2020 11:36
This was referenced Jul 24, 2020
Closed
Closed
@coveralls
Copy link

coveralls commented Jul 24, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 83.889% when pulling 5eef470 on update-deps into f8d5379 on master.

This was referenced Jul 24, 2020
Closed
Closed
@michielbdejong
Copy link
Member Author

michielbdejong commented Jul 24, 2020 •
edited
Loading

Flow is complaining about react-dom in demo/index.js. For now, I replaced the // @flow line there with a FIXME comment. fixed

@michielbdejong
Copy link
Member Author

michielbdejong commented Jul 24, 2020 •
edited
Loading

I also had to skip a few tests, and added FIXME comments there, will look into that. fixed

@michielbdejong
Copy link
Member Author

I'm seeing:
Screenshot 2020-07-28 12 55 10
Can reproduce this by running npx serve in ./dist-popup/.
Investigating.

@michielbdejong
Copy link
Member Author

michielbdejong commented Jul 28, 2020 •
edited
Loading

https://www.npmjs.com/package/preact-compat

Note: This module is for Preact 8.x and prior - Preact X includes compat by default. For Preact X, please uninstall preact-compat and replace your aliases with preact/compat.

Fixed in 927808d.

@michielbdejong
Copy link
Member Author

Screenshot 2020-07-28 13 35 12

The first warning is probably because it checks whether you're already logged in. The second one seems to be oidc-rp trying to access JWKS.importKeys from jose.

@michielbdejong
Copy link
Member Author

michielbdejong commented Jul 28, 2020 •
edited
Loading

Adding a debug statement to src/JWKSet.js in jose, then:

cd ../jose ; npm run dist ; cd ../oidc-rp ; npm run dist ; cd ../solid-auth-client ; npm run build

@michielbdejong
Copy link
Member Author

It's failing to import each key in
https://github.com/solid/jose/blob/master/src/algorithms/RSASSA-PKCS1-v1_5.js#L106
https://github.com/solid/jose/blob/master/src/jose/JWA.js#L90
https://github.com/solid/jose/blob/master/src/jose/JWK.js#L31
https://github.com/solid/jose/blob/master/src/jose/JWKSet.js#L32
Will continue investigating tomorrow.

@michielbdejong
Copy link
Member Author

michielbdejong commented Jul 28, 2020 •
edited
Loading

Fixed in nodeSolidServer/jose@1731c55.
Next error: 500 response on /register

@michielbdejong
npm install @solid/oidc-rp@latest ; rm -rf node_modules ; rm package-…
5eef470 
…lock.json ; npm install ; git add package-lock.json
@michielbdejong michielbdejong marked this pull request as ready for review July 30, 2020 10:14
@michielbdejong
Copy link
Member Author

As discussed in https://solidos.solid.community/Team/SolidOs%20team%20chat/index.ttl#this

@michielbdejong michielbdejong merged commit 0ef3059 into master Jul 30, 2020
@michielbdejong michielbdejong deleted the update-deps branch July 30, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michielbdejong @coveralls