Skip to content

Call /logout endpoint when logging out #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Call /logout endpoint when logging out #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3551d12
Merge pull request #1 from solid/master
smalinin May 24, 2018
aa0cd8d
Fix issue with OIDC Logout, the browser cookie was not updated on lo…
smalinin May 30, 2018
1ce4888
Update for OIDC Logout fix
smalinin May 31, 2018
5522f0b
Package @trust/oidc-rp is now installed from an OpenLink git repository
cblakeley Jun 1, 2018
5775ccf
Revert "Package @trust/oidc-rp is now installed from an OpenLink git …
cblakeley Jun 7, 2018
e757510
Replace HTTP GET with POST
smalinin Aug 10, 2018
c964a4e
Fix merge conflict
smalinin Aug 10, 2018
55a103a
Add missed curly braced
smalinin Aug 10, 2018
a73c3b3
Merge branch 'master' into OpenLinkSoftware-openlink_pull_req
RubenVerborgh Aug 11, 2018
c7272bd
Fix spacing.
RubenVerborgh Aug 11, 2018
abde4b4
Rewrite logout function in async style.
RubenVerborgh Aug 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export async function logout(
const session = await getSession(storage)
if (session) {
try {
await WebIdOidc.logout(storage)
await WebIdOidc.logout(storage, session.idp)
} catch (err) {
console.warn('Error logging out:')
console.error(err)
Expand Down
18 changes: 13 additions & 5 deletions src/webid-oidc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,21 @@ export const currentSession = async (
}
}

export const logout = (storage: AsyncStorage): Promise<void> =>
getStoredRp(storage)
.then(rp => (rp ? rp.logout() : undefined))
.catch(err => {
export const logout = async (
storage: AsyncStorage,
idp: string
): Promise<void> => {
const rp = await getStoredRp(storage)
if (rp) {
try {
rp.logout()
fetch(idp + '/logout', { method: 'POST', credentials: 'include' })
} catch (err) {
console.warn('Error logging out of the WebID-OIDC session')
console.error(err)
})
}
}
}

export const getRegisteredRp = (
idp: string,
Expand Down