Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning regarding nginx proxy_pass #22

Closed
Wardormeur opened this issue Nov 26, 2017 · 1 comment
Closed

Add a warning regarding nginx proxy_pass #22

Wardormeur opened this issue Nov 26, 2017 · 1 comment
Assignees

Comments

@Wardormeur
Copy link

Wardormeur commented Nov 26, 2017

Hi !
In the nginx config documentation, the proxy_pass redirect to http://127.0.0.1:4567;
By setting a "/" at the end of that url, url are decoded (https://serverfault.com/questions/459369/disabling-url-decoding-in-nginx-proxy#comment610623_463932) and hence vulnerable to XSS (NodeBB/NodeBB#4192).
It's fairly easy to make the mistake of putting an ending slash (and the proxy still work), so that a warning in the doc would be welcome.
Apart from ours instances, I've spotted a couple of websites having the same issue :)

@julianlam
Copy link
Member

Hello @Wardormeur -- very good to know! I will add the warning today, or if you'd like you can edit the files in GitHub themselves and submit a pull request 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants