Skip to content

Update of all modules with better tests #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 67 commits into from
Dec 30, 2019
Merged

Update of all modules with better tests #54

merged 67 commits into from
Dec 30, 2019

Conversation

ajfisher
Copy link
Member

@ajfisher ajfisher commented Dec 30, 2019 •
edited
Loading

  • Shift to more promise based way of working and away from callbacks where appropriate
  • Detailed test coverage across all modules
  • Broke up key functions to be more testable and maintainable
  • GitHub Actions automations to tests builds
  • More details in CHANGELOG.md
  • Closes Test set firmware details #51
  • Closes Add tests #25

ajfisher added 30 commits December 6, 2019 16:40
@ajfisher
feat(tests): Added testing structure
72f5839
@ajfisher
feat(test): Added jest test spec for firmwares
3dc708e
@ajfisher
feat(tests): Removed old nodeunit tests
dae49be
@ajfisher
feat(tests): Remove travis for build process
b4563ee
@ajfisher
chore: Added Standard version and definitions for jest
253f9ba
@ajfisher
chore: commit to bring package lock file in
8c49d60
@ajfisher
chore: Added coverage to workflow
53ff941
@ajfisher
fix: workflow bugs
1226fbb
@ajfisher
fix: workflow issues with coverage generation
56a68f2
@ajfisher
chore: Added coverage and clean up the workflows
eb0e2b4
@ajfisher
chore: Coverage job on PR only
b1d5e5b
@ajfisher
chore: fixed coverage ignore pattern
60cdece
@ajfisher
fix: Refactor the firmware listing in cli to be testable and write tests
a0c23ce
@ajfisher
chore: updated eslint definitions to 2017
ad8376b
@ajfisher
fix: refactor ports command to use promises
fb14978
@ajfisher
fix: update tests and cli to use new refactored ports
99ad915
@ajfisher
chore: tiny nits to make code more readable
5fc0858
@ajfisher
chore: changed test name
84dd959
@ajfisher
fix(tests): Added tests for temp directory removal
00712ba
@ajfisher
chore: placeholder for future tests
307458a
@ajfisher
feat: beginning refactoring of downloader with tests
901e198
@ajfisher
refactor!: Refactored the download from npm functionality tobe more a…
4664bcd 
…sync and testable
@ajfisher
chore: Added axios to the repo
523bfc5
@ajfisher
test!: Getting downloader functionality working for github end to end
39459bb
@ajfisher
fix: refactor to return hexpath in object from npm install
cfd94ea
@ajfisher
refactor: let downloader determine how to get the hex file
d02caf5
@ajfisher
interim: commit holder
0878504
@ajfisher
fix: made a test mode variable
3912786
@ajfisher
feat: added a new test firmware for gh master branch usage
369a661
@ajfisher
feat: new tests added for github downloads and refactoring to suit
b365b6c
@ajfisher
feat: Added make command to set arduino back to blink
5dcd1c6
@ajfisher
tests: more tests for flashing and supporting refactors
e828a2f
@ajfisher
test: Added scaffolding for testing the interactive CLI
7886a01
@ajfisher
test: Added tests for the questions in inquire and some small refacto…
d95e564 
…rs to support
@ajfisher
tests: Modified inquire constructor to be a promise and tests refacto…
58e15e2 
…red to support
@ajfisher
tests: Clean up of some code paths for coverage reporting
bed2c12
@ajfisher
tests: removed some console outs that are noise in tests
51f63ce
@ajfisher
tests: building out initial tests for the interchange client
61ceaa0
@ajfisher
chore: Added an unknown creator to deal with imperfect firmware respo…
17a8b83 
…nses
@ajfisher
fix: Refactored the interchange client to be more testable and moved …
94a7fc2 
…command line formatting to the cli tool
@ajfisher
fix: Tests failed and not picked up in previous commit
3d23113
@ajfisher
chore: Added husky and config to run tests before commit
63ba381
@ajfisher
fix: Made property on ic client to determine if sp is open and tests …
6b0d282 
…to support
@ajfisher
tests: Tests added for get_info method on IC Client
84879c3
@ajfisher
tests: added tests for .set_details method of interchange client
6306c4c
@ajfisher
tests: Added tests to check rejection on get_info was working
b08895c
@ajfisher
chore: updated eslint config to be allowed to use spread operator. No…
1825afb 
…de8+ FTW
@ajfisher
tests: More tests to determine if get_firmware_info works correctly
f89453c
@ajfisher
tests: Added tests for .set_firmware_details() scenarios
6a5e258
@ajfisher
chore: changed the name of a test to reflect rest of naming convention
34394c4
@ajfisher
tests: Tests to build out coverage for set firmware details in instal…
9b73480 
…l flow for #51 and #25
@ajfisher
tests: Increased coverage for npm manifest in downloader. Improves #25
34f369c
@ajfisher
tests: ignored a couple of lines that are low level lib dependent only
d467568
@ajfisher
tests: added test for rejection of get_ports
72f5ea4
@ajfisher
tests: Further tests for the inquirer process to ensure fw is sent ba…
9eb481b 
…ck okay. Helps #21
@ajfisher
chore: Removed unneeded packages from modules and package file
d198e21
@ajfisher
chore: moved changelog to more universal naming
d483e7b
@ajfisher
chore(release): 2.0.0
2fa2e25
@ajfisher ajfisher merged commit 71c2320 into master Dec 30, 2019
@ajfisher ajfisher deleted the feat/testing-buildout branch December 30, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test set firmware details Add tests

1 participant

@ajfisher