Bring life cycle in line with npm standards #1055
Conversation
We were doing our own highly custom (read: fragile) life cycle scripting for installing NodeGit. This should make it more in line with npm standards Update to latest lodash
johnhaley81
force-pushed
the
lifecycle-fixes
branch
2 times, most recently
from
b0f57f5 to
c9c8cf8
Compare
Also adds console output to let the user know a bit more about what's currently being done during install.
johnhaley81
force-pushed
the
lifecycle-fixes
branch
4 times, most recently
from
0645b33 to
2e1ac3f
Compare
johnhaley81
force-pushed
the
lifecycle-fixes
branch
4 times, most recently
from
804d2ab to
39d58e9
Compare
johnhaley81
force-pushed
the
lifecycle-fixes
branch
from
39d58e9 to
805edba
Compare
johnhaley81
force-pushed
the
lifecycle-fixes
branch
from
5c5bb8f to
e7ff929
Compare
|
I'll test it tonight 😍 |
|
Talked with john about this in person a moment ago, but putting here for records. We can't clean the source afterwards. The standard workflow for electron/nwjs is to npm install normally, then run a rebuild with the appropriate headers. This works with all other native modules i've seen, and currently works with nodegit, but cleaning the src/includes out would break that. We have to be able to run Otherwise, gonna review it up right now. |
| /build/ | ||
| /examples/ | ||
| /generate/ | ||
| /guides/ | ||
| /lib/ |
There was a problem hiding this comment.
Why ignore lib? all of our js is in there?
There was a problem hiding this comment.
lib should already be 100% built and in dist.
There was a problem hiding this comment.
That makes complete and total sense and I should have realized that, but sometimes I am do the forget.
|
This should be good now :) |
| "lodash": "~3.10.1", | ||
| "mocha": "~2.3.4", | ||
| "nan": "^2.2.0", | ||
| "node-gyp": "~3.0.3", |
There was a problem hiding this comment.
The gyp exclusions make me SO GODDAMNED HAPPY.
|
I'm so far removed from the lifecycle hooks code lately, but this looks v. good, nice work! |
johnhaley81
force-pushed
the
lifecycle-fixes
branch
from
a2f0315 to
5119bb9
Compare
|
@tbranyen There are a lot of improvements in npm3, but there are some definite regressions, and it doesn't fix the fact that npm2 is bundled with node 4 which is LTS :/ By excluding having to generate the code in our bundles, we just have to configure libssh2 if needed, ensure our deps are all installed when we run node-pre-gyp (this is not guaranteed properly in npm2, but it is in npm3 and trying to insure it ourself anyways actually breaks in npm3). We fall back to the default node-gyp now, since all that confusion was from A) node 0.8 and then came back in iojs 1/2. A lot has changed, but overall the process is easier to follow now in npm3. |
|
🎉 |
We were doing our own highly custom (read: fragile) life cycle scripting for installing NodeGit.
This should make it more in line with npm standards.