WIP New installer. #140
Merged
WIP New installer. #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -210,7 +210,7 @@ git_remote *GitRemote::GetValue() { | |||
| baton->remote = ObjectWrap::Unwrap<GitRemote>(args.This())->GetValue(); | |||
| NanAssignPersistent(Value, baton->directionReference, args[0]); | |||
| git_direction from_direction; | |||
| from_direction = (git_direction) args[0]->ToNumber()->Value(); | |||
| //from_direction = (git_direction) args[0]->ToNumber()->Value(); | |||
There was a problem hiding this comment.
This cast fails in Windows.
- Converted to Promises. - Providing support for Windows. - Normalize paths correctly based on platform.
I took the latest binding and made it work with the existing to resolve the build failure.
This has taken me hours to figure out, but in order to get Windows working a few issues had to be resolved: - Casting. I've added an additional argument parameter in the libgit2 JSON API to allow for special cast provisioning in the case where direct casting isn't possible. - Update libgit2 build flags to not use STDCALL when compiling in Windows. - Updated the binding.gyp file to have the correct configuratoin necessary for cross platform compiling.
|
Since this actually allows you to install in Windows and everything passes, I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View the PR diff at this URL to avoid seeing whitespace changes: https://github.com/nodegit/nodegit/pull/140/files?w=1
Currently failing on Windows. I've commented out two offending casting lines that will need to be addressed later. Lets get this thing build and linked first!
I need help with the binding.gyp file. I've tried many combinations and it currently does build, just link errors all over the place for every libgit2 external symbol. Definitely doing something wrong.
If you want to help fix this:
(Ensure you have cmake and python2 installed first)