Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo revert of refactored code #7

Merged
merged 1 commit into from
Aug 20, 2015
Merged

Undo revert of refactored code #7

merged 1 commit into from
Aug 20, 2015

Conversation

johnhaley81
Copy link
Contributor

No description provided.

@johnhaley81
Copy link
Contributor Author

The problem is actually with nodegit and that we were relying on a bug to get our stuff to work instead of using the built in functionality of promisify.

So in the old version of promisify, if you pass in just a function it would promisify it even if it didn't fulfill the internal criteria for promisification (Is that a word???)

So now I just had to change some nodegit code to get it to work.

So in the next release of nodegit we can use the newest and latest and greatest version of promisify.

But we can't merge this in and re-publish promisify until nodegit gets a version bump.

@tbranyen
Copy link
Member

Should I merge this?

@johnhaley81
Copy link
Contributor Author

I think so. We should do a version bump of this library as well. I don't want something unexpectedly breaking in nodegit.

@johnhaley81
Copy link
Contributor Author

I'm merging this and then I'll update nodegit accordingly. We should major version bump since I had to change to the latest nodegit-promise as well.

johnhaley81 added a commit that referenced this pull request Aug 20, 2015
Undo revert of refactored code
@johnhaley81 johnhaley81 merged commit 16ebf62 into master Aug 20, 2015
@johnhaley81
Copy link
Contributor Author

So we'll need better tests for this library. Apparently this is breaking a lot of stuff not even related to nodegit. I'm reverting this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants