-
Notifications
You must be signed in to change notification settings - Fork 43
Node's HTTP(S) and Streams for uploading files #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…am; test with custom stream
Ohh heh, perhaps node's core HTTPS API actually works now? :-D @indexzero will definitely take a look at this. Thanks! |
Added req.end() and res.destroy() so the request is ended and the socket is explicitly closed after response. |
Added Expect: 100-continue header, fixes larger file uploads. |
@kschzt I will look at this in the next couple of days. At first glace it seems like the |
Can't wait for the stream functionality! When is it planned to add this to the master branch? |
@RobinvdVieuten Sometime soon, some other things on our plate first |
@indexzero I will use the version of @kschzt in the meantime then. I can imagine that you have a lot on your plate with all that awesome modules you are developing ;) |
@robinvdvleuten @kschzt This is now merged into the Passing all tests, but I'm hold off on publishing until I can make some new tests to large file uploads (i.e. |
@robinvdvleuten @kschzt This is now merged into master and published to npm as |
Great! Thanks for that @indexzero |
Hi,
I rewrote the rackspaceCurl method using Node's HTTP(S) and Streams. This is so that I can provide a custom in-memory Stream.
All tests pass.
BR,
Jak