Skip to content

Conversation

kschzt
Copy link

@kschzt kschzt commented Jul 19, 2011

Hi,

I rewrote the rackspaceCurl method using Node's HTTP(S) and Streams. This is so that I can provide a custom in-memory Stream.

  • Use Node's HTTP(S) and Streams to upload files
  • Renamed rackspaceCurl to rackspaceRequest
  • Allow providing custom Stream
  • Add test for custom stream

All tests pass.

BR,

Jak

@Marak
Copy link

Marak commented Jul 19, 2011

Ohh heh, perhaps node's core HTTPS API actually works now? :-D

@indexzero will definitely take a look at this. Thanks!

@kschzt
Copy link
Author

kschzt commented Jul 20, 2011

Added req.end() and res.destroy() so the request is ended and the socket is explicitly closed after response.

@kschzt
Copy link
Author

kschzt commented Jul 20, 2011

Added Expect: 100-continue header, fixes larger file uploads.

@indexzero
Copy link
Member

@kschzt I will look at this in the next couple of days. At first glace it seems like the .rackspaceRequest() method could be rolled into the existing .rackspace() method. I broke them out into two methods originally because large file uploads over HTTPS didn't work properly in node. That was 0.3.x though, so I'm sure it's better now.

@robinvdvleuten
Copy link

Can't wait for the stream functionality! When is it planned to add this to the master branch?

@indexzero
Copy link
Member

@RobinvdVieuten Sometime soon, some other things on our plate first

@robinvdvleuten
Copy link

@indexzero I will use the version of @kschzt in the meantime then. I can imagine that you have a lot on your plate with all that awesome modules you are developing ;)

@indexzero
Copy link
Member

@robinvdvleuten @kschzt This is now merged into the 0.3.x branch. I made some pretty significant changes to take advantage of the stream objects returned from the latest version(s) of [request)(http://github.com/mikeal/request).

Passing all tests, but I'm hold off on publishing until I can make some new tests to large file uploads (i.e. > ~1.5Mb)

@indexzero indexzero closed this Aug 14, 2011
@indexzero
Copy link
Member

@robinvdvleuten @kschzt This is now merged into master and published to npm as cloudfiles@0.3.0.

@robinvdvleuten
Copy link

Great! Thanks for that @indexzero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants