Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt devsnek/node-repl-prototype into org #168

Closed
devsnek opened this issue Jun 22, 2018 · 9 comments
Closed

adopt devsnek/node-repl-prototype into org #168

devsnek opened this issue Jun 22, 2018 · 9 comments

Comments

@devsnek
Copy link
Member

devsnek commented Jun 22, 2018

i started prototyping out a repl rewrite for node and opened a pr (nodejs/node#21396) but @joyeecheung suggested i should bring the repo into the org let it iterate outside of core for a while.

repo in question: https://github.com/devsnek/node-repl-prototype

i'm pretty sure i've made all the adjustments asked for in #68

/cc @nodejs/community-committee @nodejs/tsc

@targos
Copy link
Member

targos commented Jun 22, 2018

sgtm

@joyeecheung
Copy link
Member

+1

2 similar comments
@TimothyGu
Copy link
Member

+1

@mhdawson
Copy link
Member

+1

@devsnek
Copy link
Member Author

devsnek commented Jul 4, 2018

does anything else need to happen before i actually transfer the repo?

@mhdawson
Copy link
Member

mhdawson commented Jul 4, 2018

@nodejs/tsc, @nodejs/community-committee if there are no objections by the end of the week, we will consider this approved.

@devsnek
Copy link
Member Author

devsnek commented Jul 9, 2018

should be good to transfer now right?

@TimothyGu
Copy link
Member

@devsnek Sounds good to me.

@devsnek
Copy link
Member Author

devsnek commented Jul 9, 2018

transferred! thanks everyone :D

@devsnek devsnek closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants