Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: move uvwasi to the nodejs org #578

Closed
cjihrig opened this issue Jan 9, 2021 · 16 comments
Closed

Proposal: move uvwasi to the nodejs org #578

cjihrig opened this issue Jan 9, 2021 · 16 comments

Comments

@cjihrig
Copy link

cjihrig commented Jan 9, 2021

I'm opening this issue to see if there is any interest in moving uvwasi into the nodejs org. uvwasi is the bulk of Node's current WASI implementation.

Disclaimer: I am planning to limit my involvement on that project moving forward regardless of where it is hosted.

@mcollina
Copy link
Member

Are you planning to work on it somehow, or are others planning to do so?

(I'm generically +1)

@cjihrig
Copy link
Author

cjihrig commented Jan 10, 2021

I'm not planning to continue working on it myself, but others are more than welcome to do so.

@guybedford
Copy link
Contributor

+1, I think this would be worthwhile to maintain for Node.js going forward.

@cjihrig
Copy link
Author

cjihrig commented Jan 11, 2021

cc'ing @nodejs/tsc and @nodejs/community-committee for proper visibility of the issue.

@mmarchini
Copy link
Contributor

+1

Assuming there are no objections we can transfer it in 72h (72h is the wait time per our policy, but since tsc and commcomm were only cc'd today I suggest starting to count now so folks have time to review the request).

In the meantime, if you want to speed up the process, you can check if the following files exist in the repository (and create those that don't exist):

  • CODE_OF_CONDUCT.md: it can be a reference to the Node.js Code of Conduct.
  • CONTRIBUTING.md: if there isn't one already, the contributing guide of Node.js core could be a good example. Consider including the Developer's Certificate of Origin section in the document to avoid potential copyright conflicts.
  • LICENSE, or other kind of documents that describe the license of the project.
  • README.md

@mcollina
Copy link
Member

+1

1 similar comment
@mhdawson
Copy link
Member

+1

@jasnell
Copy link
Member

jasnell commented Jan 11, 2021

While I'm generally +1, I'm concerned about the lack of maintainers. We either need to find some people willing to move WASI support in Node.js forward or we need to remove it.

@cjihrig ... would you see any reason why the WASI stuff couldn't be implemented as a native addon?

@mhdawson
Copy link
Member

@jasnell I agree with the concern over maintainers, but figure that if what we have is a copy having it in the repo would make sense until we figure out what next steps are. Although maybe I need to better understand if uvwasi is the bulk of Node's current WASI implementation means and how transferring the repo helps support what we already have in core (if it does)

@cjihrig
Copy link
Author

cjihrig commented Jan 12, 2021

We either need to find some people willing to move WASI support in Node.js forward or we need to remove it.

I'm also fine with sending a PR to remove it if that is what is preferred.

would you see any reason why the WASI stuff couldn't be implemented as a native addon?

From a technical perspective I think it's possible.

@jasnell
Copy link
Member

jasnell commented Jan 12, 2021

I'm also fine with sending a PR to remove it if that is what is preferred.

Don't get me wrong, I'm not saying that removing it is preferred. It just might make it easier to find contributors/maintainers if it is.

@gireeshpunathil
Copy link
Member

+1 to moving to core
+1 to implement natively, but not a pre-req for moving

@MylesBorins
Copy link
Contributor

Thank you for all the hard work on this up until now @cjihrig

I think there is a lot of value in us shipping this built into core, WASI + WASM is a potential platform agnostic backend for natively compiled modules. That said we absolutely need to have maintainers. Perhaps we could reach out to Bytecode Alliance as well as W3C folks working on WASI to see if we can get any people interested.

While I can't personally devote the time to work on implementation I would be willing to help find folks to pitch in.

@danbev
Copy link

danbev commented Jan 12, 2021

+1 I'm interested in helping maintaining/contributing.

@cjihrig
Copy link
Author

cjihrig commented Jan 14, 2021

If no formal objections are raised, I plan to transfer the repo this weekend.

cjihrig added a commit to nodejs/uvwasi that referenced this issue Jan 16, 2021
@cjihrig
Copy link
Author

cjihrig commented Jan 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants