Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark scripts used by an active Jenkins job are archived #762

Open
legendecas opened this issue Jan 16, 2023 · 6 comments
Open

Benchmark scripts used by an active Jenkins job are archived #762

legendecas opened this issue Jan 16, 2023 · 6 comments

Comments

@legendecas
Copy link
Member

legendecas commented Jan 16, 2023

The benchmark job https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/ is using the script https://github.com/nodejs/benchmarking/blob/master/experimental/benchmarks/community-benchmark/run.sh to run the benchmarks.

The script is cloning the repo with the HTTP protocol http://github.com/nodejs/node.git (it's been redirected to use HTTPS protocol automatically). Probably worth updating the script to use HTTPS instead.

However, the repository https://github.com/nodejs/benchmarking has been archived and can not be updated. Should we move the benchmarking scripts to a dedicated repo since the benchmarking working group has been de-chartered?

@RafaelGSS
Copy link
Member

What about moving it to node/tools?

@legendecas
Copy link
Member Author

What about moving it to node/tools?

This can be an option. Or we can put it in https://github.com/nodejs/build/tree/main/jenkins/scripts like other Jenkins scripts.

@RafaelGSS
Copy link
Member

I think the latter is a good choice, indeed.

cc: @nodejs/build

@nschonni
Copy link
Member

There is a PR to remove that stuff from the build repo too nodejs/build#3145

@richardlau
Copy link
Member

See also nodejs/build#3277.

We could always unarchive https://github.com/nodejs/benchmarking. Would @nodejs/performance be interested in owning it?

You could open a PR to move the script to https://github.com/nodejs/build/tree/main/jenkins/scripts, but then every change to that script is going to be bottlenecked on the Build WG.

@anonrig
Copy link
Member

anonrig commented Apr 3, 2023

I think we should keep it under nodejs/build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants