Fix parsing of command line, so usage works #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/releasers -- PTAL |
BridgeAR
reviewed
Apr 26, 2019
Documented CLI of ./branch-diff.js --simple master fix-cli-flags doesn't work, minimist assumes master is the value of `--simple` option, it needs to be told about options that don't take values.
|
PTAL |
|
/cc @MylesBorins @rvagg who have publish rights on npm |
BridgeAR
approved these changes
Jun 4, 2019
|
code style isn't the same as core here so this'll need to be fixed to match, I'll try and get around to that today |
Merged
|
pulled this in to #18 along with formatting fixes and some other updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented CLI of
branch-diff --simple master fix-cli-flags
doesn't work, minimist assumes master is the value of
--simpleoption,it needs to be told about options that don't take values.