Skip to content

Conversation

Fishrock123
Copy link
Contributor

Allow a fallback to author checking. Sometimes people miss the PR-URL part. :)

This warns (but only if stdio is a TTY) if it happens so you can check the commits to make sure.

branch-diff.js Outdated

This comment was marked as off-topic.

@rvagg
Copy link
Member

rvagg commented Jan 12, 2016

I think I'd prefer not being on by default but making it available behind a flag. An additional extra might be to print something along with commits that don't have a PR-URL so it's more obvious—currently it prints the PR details but it doesn't stand out when missing unless you're looking for it. Maybe (No PR-URL).

branch-diff.js Outdated

This comment was marked as off-topic.

This comment was marked as off-topic.

@Fishrock123
Copy link
Contributor Author

I think I'd prefer not being on by default but making it available behind a flag.

Ehhh, we're already giving this thing like 6 long args haha

Should we just start checking the first two lines of the description or something?

@Fishrock123
Copy link
Contributor Author

currently it prints the PR details but it doesn't stand out when missing unless you're looking for it. Maybe (No PR-URL).

This is a little less useful when you want to pipe this into something that automatically applies the commits. :)

@rvagg
Copy link
Member

rvagg commented Jan 14, 2016

Ehhh, we're already giving this thing like 6 long args haha

Hey, this is a git-related tool remember! Long and confusing commandlines are the norm.

rvagg pushed a commit that referenced this pull request Jan 14, 2016
@rvagg
Copy link
Member

rvagg commented Jan 14, 2016

OK, I pulled this down and had a play and agree that it's nice to have. Thanks!

@rvagg rvagg closed this Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants