-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-test-commit: run make doc during tests #887
Comments
Refs: nodejs/node#14930 (2 cases) |
@maclover7 thanks for following up on this.
|
Looks like this happened again (see nodejs/node#14930 (comment) for details). Personally, I still think compiling docs via node-test-commit (or node-test-linter) is the best solution. I see @gibfahn and @mhdawson gave a +1 to @refack's comment above... what's the best way to move forward here? |
So assuming we're doing this:
that would just be a PR to nodejs/node that added a test in |
PR-URL: #16208 Fixes: nodejs/build#887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Implement common.projectDir which points to the project directory. PR-URL: #16208 Fixes: nodejs/build#887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #16208 Fixes: nodejs/build#887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Implement common.projectDir which points to the project directory. PR-URL: nodejs/node#16208 Fixes: nodejs/build#887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: nodejs/node#16208 Fixes: nodejs/build#887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: nodejs/node#16208 Fixes: nodejs/build#887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Implement common.projectDir which points to the project directory. PR-URL: nodejs/node#16208 Fixes: nodejs/build#887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Running
make doc
(and making sure the exit status is 0) can help with nodejs/node#15447. I think the chances a YAML error would be introduced are low, but it would be great to catch this via CI as an early warning system, and not via checking the nightly doc builds :)cc @refack @vsemozhetbyt
The text was updated successfully, but these errors were encountered: