-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jenkins: add llnode pipeline and shell scripts #1025
Conversation
Good point, added. Also added a check, as the parameters don't always show up until the second time you run the pipeline. |
Ping @gibfahn |
@gibfahn would you mind if I move forward with this? Looks like Travis on llnode just broke again (our 2 last builds are stuck), so it would be nice to move our tests to Jenkins. |
Commit updating Node.js versions: mmarchini@b918f24 I tested with |
Works for me, but it would be good to have some input from more Jenkins-y folks like @joaocgreis @maclover7 @rvagg @refack .... |
There are a few outstanding review comments that @gibfahn should look at (I, at least personally, am not super familiar with this PR and how it will work, and don't really feel comfortable trying to address those) -- if we don't hear back for a little while longer, we can take another look |
@mmarchini I applied your tweak to the pipeline spec. Since the job runs using the code from @gibfahn's fork it should now be updated. |
@refack I just uploaded a new patch, can you cherry-pick it into This patch will fix the test runs for Linux and Mac OS by downloading LLDB from http://releases.llvm.org/download.html. It assumes we're only testing on Ubuntu 16.04 and Mac OS for now, which I think is fine for now, since those are the tests we currently have on llnode with Travis. I also added |
More shaving got us to: seems like lldb is not part of the tarball root@test-rackspace-ubuntu1604-x64-2:/home/iojs/build/workspace/llnode-continuous-integration/LLDB/4.0/MACHINE/ubuntu1604-64/llvm-bin# ls bin
bugpoint clang-change-namespace clang-func-mapping clang-rename ld.lld llvm-as llvm-c-test llvm-dlltool llvm-link llvm-mt llvm-profdata llvm-size llvm-xray scan-build
c-index-test clang-check clang-import-test clang-reorder-fields llc llvm-bcanalyzer llvm-cvtres llvm-dsymutil llvm-lto llvm-nm llvm-ranlib llvm-split modularize scan-view
clang clang-cl clang-include-fixer clang-tidy lld llvm-cat llvm-cxxdump llvm-dwarfdump llvm-lto2 llvm-objcopy llvm-rc llvm-stress obj2yaml verify-uselistorder
clang++ clang-cpp clang-offload-bundler find-all-symbols lld-link llvm-cfi-verify llvm-cxxfilt llvm-dwp llvm-mc llvm-objdump llvm-readelf llvm-strings opt wasm-ld
clang-6.0 clangd clang-query git-clang-format lli llvm-config llvm-diff llvm-extract llvm-mcmarkup llvm-opt-report llvm-readobj llvm-symbolizer sancov yaml2obj
clang-apply-replacements clang-format clang-refactor ld64.lld llvm-ar llvm-cov llvm-dis llvm-lib llvm-modextract llvm-pdbutil llvm-rtdyld llvm-tblgen sanstats |
Interesting. I tested only with 3.9.0, and lldb was there. Let me see why it's missing from 6.0.0 |
I actually forgot the global LLDB in my path while testing, my bad. clang+llvm doesn't come with LLDB, and I'm having trouble finding a source to download it from. |
Killed the matrix. |
I have not yet find a way to get reliable prebuilt lldb binaries either. Here is a gist that I wrote some time ago when I needed to test llnode on different linux distros: |
Is Xcode installed in our OSX machines? If so we can use the LLDB that comes with it, and use Docker to test on Linux. What do you think? |
We should have "Xcode Command Line Tools" on the macOS machines. |
New patch, tested on Ubuntu 16.04 (this time without having a global lldb installed): I went with the "download the .deb and extract it" approach. OSX will still fail, but let's fix one OS at a time :) |
Shaved it some more (
https://ci.nodejs.org/job/llnode-continuous-integration/47/default/ |
The llnode CI isn't working right now, but hopefully by committing this we can then iterate in GitHub. Refs: nodejs#777
* misc fixes * americanize colour spelling * adjustments refack: * Update llnode-pipeline.jenkinsfile * debug
* Missing pipe? * --compressed * One more deb? * Update llnode-continuous-integration.sh
@refack is there anything left to be done here? If so, can I help? |
@mmarchini you should now have write permissions to the underlying branch - ttps://github.com/gibfahn/build/tree/llnode-ci |
The llnode CI isn't working right now, but hopefully by committing this
we can then iterate in GitHub.
This also makes the node download script runnable manually, and adds docs for it.
@joyeecheung I was thinking if we land this, you can raise a PR to build, and build the jobs directly from your PR. Thoughts?