Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code and Learn at Node.js Interactive in Amsterdam #56

Closed
mikeal opened this issue Apr 18, 2016 · 70 comments

Comments

Projects
None yet
@mikeal
Copy link
Contributor

commented Apr 18, 2016

So, I'd like to resurrect this event to run either before or after the Node.js Interactive events in Amsterdam and Austin.

We need to figure out what this will look like so that we can budget it correctly.

As a reminder, this program was intended as a series of workshops for getting people working on Node.js itself. The goal was that by the end of the workshop they would have a PR open, or be close to it.

We need to put together a list of subjects, people that can properly mentor the subject, and if those people need their travel covered we need to know where they are coming from. Also, for each subject and mentor allocation we need to figure out the maximum size of the attendees.

/cc @dshaw @ashleywilliams @hackygolucky @Fishrock123

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

I'd be up for helping with this, obviously dependent on me attending the events

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

Amsterdam is my home turf (after a fashion) so I'll volunteer. I request remuneration only for the train ticket but I do tend to travel 1st class exclusively so there's that.

@iancrowther

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2016

happy to chip in

@mikeal

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2016

We really need someone to step up to lead this effort at Amsterdam and Austin (doesn't need to be the same person each time).

@jasnell

This comment has been minimized.

Copy link
Member

commented Aug 11, 2016

I can help as a mentor on site. Going to be fairly busy I think so I don't want to overcommit as 'lead'

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Aug 11, 2016

@mikeal would this be running during the collaborator summit? Do we have resources to offer individuals, potentially with a focus on under represented groups, continued support after a code and learn?

I think it might be particularly interesting to pair current collaborators with new collaborators. It might also be great if we can offer some sort of scholarship to individuals in need so that they can focus a continued effort on getting involved.

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Aug 12, 2016

Which day is this at in Amsterdam?

I may be able to help but I definitely don't want to lead it.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Aug 12, 2016

I can lead but it depends on what day it is. (EDIT: In Amsterdam.)

@mikeal

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2016

Morning of the 17th.

@addaleax

This comment has been minimized.

Copy link
Member

commented Aug 12, 2016

I’ll definitely want to be there and can probably also invest some time into it beforehand.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Aug 13, 2016

How morning is morning? 17th works for me but I need to drive up from Groningen. I can be there around 11 am.

@addaleax

This comment has been minimized.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Aug 17, 2016

Thanks, that page was still blank last I checked. :-)

I don't think I'll be able to make 9 am, I'd have to leave before 6 am.

@mikeal

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2016

Heya, do you need anything from the events team?

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

I won't be there fwiw.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

So who is going to lead?

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

If nobody else is available, I can try to, even as a newbie… I’d definitely want to talk with people who have done this before in that case

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

im up for being involved, let me know what I can do to help

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

IRC or email? Don't worry, the biggest thing is to have some 'good first contribution' issues stacked up, everything else flows from there (after walking people through how to build first.)

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

hm, how about in IRC in an hour (I’m busy until then), maybe with @thealphanerd too?

@jasnell

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

I will be there also and can definitely help in any way that I can but I'm more than happy for @addaleax or others to take the lead if they'd like.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

I have cheese/bacon pancakes and a Danish krimi to attend to first but I'll hop onto IRC afterwards. Make it 1.30h from now.

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

oh, have fun! and yeah, works for me :)

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

ping me when ya’ll are ready, I should be around

On Sep 8, 2016, at 1:12 PM, Anna Henningsen notifications@github.com wrote:

oh, have fun! and yeah, works for me :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #56 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAecV7QpUzKw2TFFAtUhK-7ojlm2T4I6ks5qoEHogaJpZM4IKMKM.

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 9, 2016

oh, yeah, seems I forgot to comment… I should be able to lead this :)

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 15, 2016

Okay, so from what I’ve gathered by talking to a few people here, the expectations for Code & Learn are a bit diverse, as are the skill levels of attending people. I’ve gathered a few changes that people might up to do, maybe that’s enough (I’ll definitely gather a bit more), but I’m pretty sure that even if not we’re going to be able to provide attendees with things they’re interested in (@saghul even offered to help people with first libuv contributions if they’re interested in that!).

A few things that I think are okay:

  • lib/internal/bootstrap_node.js
    • The NativeModule._cache can safely be turned into a Map!
    • var -> const substitutions
  • lib/v8.js, src/node_v8.cc:
    • There are a few fields missing on HeapStatistics which have been added in more recent V8 versions:
      • malloced_memory
      • peak_malloced_memory
      • does_zap_garbage
  • lib/util.js:
    • i): The SIMD setup can be turned into a loop and the typeof checks can be removed
    • ii): Support for SharedArrayBuffer can be added here, too.
    • iii): (Maybe) The catch-all try check in tryStringify() for circular objects is probably too unspecific
  • src/udp_wrap.cc, src/stream_base.cc:
    • The uv_buf_t bufs_[16] lines could be MaybeStackBuffers;
  • lib/internal/process.js
    • (Maybe) We might want to emit a warning for signals that users shouldn’t listen on (as listed in the docs warning in nodejs/node#8410)?
  • lib/internal/lazy_transform.js
    • The default encoding here should be configurable and default to crypto.DEFAULT_ENCODING, not latin1?. This seems to kind of have been forgotten in nodejs/node#5522 – It would be a semver-major change, but I think this is not going to be contentious.
  • edit: nodejs/node#3208

And a few test files that could be cleaned up in NodeTodo/@Trott style:

  • test-c-ares.js:
    • A lot of vars that can be const
    • assert.strictEqual should be used instead of assert.equal
    • Wrap all callbacks that should be called once in common.mustCall()
  • test-child-process-buffering.js:
    • A lot of vars that can be const
    • assert.strictEqual should be used instead of assert.equal
  • test-child-process-detached.js
    • A lot of vars that can be const
    • assert.notStrictEqual should be used instead of assert(… !== …)
  • test-child-process-stdio.js:
    • A lot of vars that can be const
    • assert.strictEqual should be used instead of assert.equal, the same goes for notEqual
  • test-child-process-stdout-flush.js:
    • A lot of vars that can be const
    • assert.strictEqual should be used instead of assert.equal, the same goes for notEqual
    • Wrap all callbacks that should be called once in common.mustCall()

Tomorrow we might get a better picure of how many people would be able and willing to attend (maybe @mikeal could ask a quick question when he mentions Code & Learn during the final notes)?

And @mikeal … not sure whether it makes a difference, but maybe we could add your “It's a workshop for people who want to learn how to contribute to Node.js core.” at the beginning and drop the whole “Concerns have also … need to be distributed geographically” part? I think that should clear up everything sufficiently.

/cc a couple of people who are here: @mhdawson @jasnell @bnoordhuis @saghul @mcollina @mikeal @thealphanerd

@saghul

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

Great work putting that together @addaleax! FWIW, I tagged some issues as good first contributions to libuv here: https://github.com/libuv/libuv/labels/good-first-contribution So if anyone what's to go for it, I'm happy to help as a mentor.

@jasnell

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

wow... amazing list! To this I would add that there are a number of issues tagged as docs-requested that could be accessible to some participants.

@sejoker

This comment has been minimized.

Copy link

commented Sep 17, 2016

I would like to pickup test cleanup of test-c-ares.js from @addaleax proposed list

@wzoom

This comment has been minimized.

Copy link

commented Sep 17, 2016

DONE Working on test-child-process-cwd.js

@Thylossus Thylossus referenced this issue Sep 17, 2016

Closed

test: refactored test-crypto-random.js #8632

2 of 2 tasks complete

pmatzavin added a commit to pmatzavin/node that referenced this issue Sep 19, 2016

test: refactor equality assertions
issue: nodejs/code-and-learn#56(comment)

modified file: test/parallel/test-child-process-stdio.js

Replace the equal assetion with strictEqual.
Replace the notEqual assertion with strictNotEqual.

@imyller imyller referenced this issue Sep 19, 2016

Closed

test: minor replace var by const #8621

3 of 3 tasks complete

jasnell added a commit to nodejs/node that referenced this issue Sep 22, 2016

test: update test/parallel/test-child-process-stdio.js
Refs: nodejs/code-and-learn#56(comment)

Replace the equal assetion with strictEqual.
Replace the notEqual assertion with strictNotEqual.

PR-URL: #8584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>

imyller added a commit to imyller/node that referenced this issue Sep 23, 2016

process: changed var to const in internal/process.js
PR-URL: nodejs#8614
Refs: nodejs/code-and-learn#56
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

jasnell added a commit to nodejs/node that referenced this issue Sep 29, 2016

test: update test/parallel/test-child-process-stdio.js
Refs: nodejs/code-and-learn#56(comment)

Replace the equal assetion with strictEqual.
Replace the notEqual assertion with strictNotEqual.

PR-URL: #8584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>

jasnell added a commit to nodejs/node that referenced this issue Sep 29, 2016

process: changed var to const in internal/process.js
PR-URL: #8614
Refs: nodejs/code-and-learn#56
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

Fishrock123 added a commit to nodejs/node that referenced this issue Oct 11, 2016

test: update test/parallel/test-child-process-stdio.js
Refs: nodejs/code-and-learn#56(comment)

Replace the equal assetion with strictEqual.
Replace the notEqual assertion with strictNotEqual.

PR-URL: #8584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>

Fishrock123 added a commit to nodejs/node that referenced this issue Oct 11, 2016

process: changed var to const in internal/process.js
PR-URL: #8614
Refs: nodejs/code-and-learn#56
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@bengl

This comment has been minimized.

Copy link
Member

commented Oct 13, 2016

Is there a thread to organize this for Austin?

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 13, 2016

@bengl I don’t think so, so: #59

@Trott Trott changed the title Code and Learn at Node.js Interactive Code and Learn at Node.js Interactive in Amseterdam Oct 13, 2016

@Trott

This comment has been minimized.

Copy link
Member

commented Oct 13, 2016

Closing because this happened and planning for the next one is over in #59. As always, feel free to re-open or comment if you feel this really shouldn't be closed.

@Trott Trott closed this Oct 13, 2016

@AdriVanHoudt

This comment has been minimized.

Copy link
Member

commented Oct 14, 2016

@Trott you made a slight typo in Amsterdam ;)

@Trott Trott changed the title Code and Learn at Node.js Interactive in Amseterdam Code and Learn at Node.js Interactive in Amsterdam Oct 14, 2016

@hackygolucky

This comment has been minimized.

Copy link
Member

commented Oct 14, 2016

There is now! #60

On Thu, Oct 13, 2016, 7:02 PM Anna Henningsen notifications@github.com
wrote:

@bengl https://github.com/bengl I don’t think so, so: #59
#59


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#56 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB46oKRQiRiPtlaqirLpJt4PI1ndUBEKks5qzrh3gaJpZM4IKMKM
.

addaleax added a commit to nodejs/node that referenced this issue Nov 20, 2016

src: extend `HeapStatistics` with new fields
src: Add does_zap_garbage, malloced_memory and
peak_malloced_memory to v8 HeapStatistics

Following nodejs/code-and-learn#56 I
have exposed does_zap_garbage to HeapStatistics.
The other fields, malloced_memory and peak_malloced_memory don't
seem to be in the current version of v8 in master.

PR-URL: #8610
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax added a commit to nodejs/node that referenced this issue Nov 22, 2016

src: extend `HeapStatistics` with new fields
src: Add does_zap_garbage, malloced_memory and
peak_malloced_memory to v8 HeapStatistics

Following nodejs/code-and-learn#56 I
have exposed does_zap_garbage to HeapStatistics.
The other fields, malloced_memory and peak_malloced_memory don't
seem to be in the current version of v8 in master.

PR-URL: #8610
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.