Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Adding new Champion for Website Redesign team #627

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Adding new Champion for Website Redesign team #627

merged 2 commits into from
Aug 6, 2020

Conversation

designMoreWeb
Copy link
Contributor

PR for issue

Also would like to request a liaison from the @nodejs/community-committee

@designMoreWeb
Adding new Champion
58b20e1 
Updated website redesign champion
@designMoreWeb designMoreWeb mentioned this pull request Jun 19, 2020
Closed
@bnb bnb added the cc-agenda label Jun 25, 2020
keywordnew
keywordnew approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bnb
bnb suggested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Champions need to be CommComm members, or need to have a CommComm member as a Liaison. We should really try to stick with this model and have a CommComm member active/championing, have someone volunteer as a liaison, or reevaluate this approach.

@mhdawson mhdawson mentioned this pull request Jul 6, 2020
Closed
@mhdawson mhdawson mentioned this pull request Jul 20, 2020
Closed
@designMoreWeb
Updated new champion with liason
ca0cd2a 
Added obensource as liason from Com-com
@designMoreWeb
Copy link
Contributor Author

Just updated the PR as discussed in the ComCom meeting today

@mhdawson mhdawson mentioned this pull request Aug 3, 2020
Closed
@bnb bnb merged commit ae59a64 into nodejs:master Aug 6, 2020
@bnb bnb removed the cc-agenda label Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keywordnew keywordnew keywordnew approved these changes

@mhdawson mhdawson mhdawson approved these changes

@ahmadawais ahmadawais ahmadawais approved these changes

@bnb bnb bnb approved these changes

@joesepi joesepi joesepi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@designMoreWeb @joesepi @bnb @ahmadawais @mhdawson @keywordnew