ci: fix the Sync workflow #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Jun 1, 2022
Co-authored-by: Maël Nison <nison.mael@gmail.com>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jun 1, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment)
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jun 1, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment)
arcanis
approved these changes
Jun 1, 2022
merceyz
reviewed
Jun 1, 2022
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
aduh95
added a commit
to nodejs/node
that referenced
this pull request
Jun 5, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 6, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: nodejs#43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
It looks like using a hash breaks the workflow: https://github.com/nodejs/corepack/runs/6741674996?check_suite_focus=true 🤔 |
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 11, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 13, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 13, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 12, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 31, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: #43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Using tags is a security risk, as they can be updated to point to anything else. Refs: nodejs/corepack#117 (comment) PR-URL: nodejs/node#43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Sync workflow is failing because GitHub Actions do not have permission to commit to the
mainbranch. Instead, we can ask it to create a PR, which has the upside of making sure the job is not committing ill-formed data to themainbranch.Other changes:
git showinstead of a temporary file.