-
-
Notifications
You must be signed in to change notification settings - Fork 44
feat: use JSON, templates, npx, and add dry-run support #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: use JSON, templates, npx, and add dry-run support #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR performs a major refactoring to improve the developer experience by migrating from INI/env files to JSON configurations, replacing custom templating with Mustache, adding dry-run support, and enabling npx-style usage. The primary goal is to simplify configuration management and reduce maintenance overhead.
- Migrates configuration from templates/ directory with custom parsing to structured JSON configs/ directory
- Replaces custom template system with industry-standard Mustache templating
- Adds --dry-run flag for testing without creating artifacts
Reviewed Changes
Copilot reviewed 117 out of 142 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/index.mjs | New main entry point with Commander.js CLI and dry-run support |
template.hbs | Single Mustache template replacing multiple custom templates |
configs/*.json | JSON configuration files replacing template-based config system |
src/meeting.mjs | Simplified meeting logic using JSON configs and Mustache |
package.json | Updated dependencies and entry points for npx support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
819adb5
to
37d1262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 117 out of 142 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/config.mjs:1
- The comments reference outdated configuration properties. The
meetingGroup
is now handled by commander insrc/index.mjs
, andgoogle.clientId
is not used anywhere in the codebase. These comments should be updated to reflect the actual usage.
/**
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c4b93cb
to
6436c01
Compare
6436c01
to
0ea464b
Compare
Fixes #3
Closes #185
This PR makes a few substantial changes to improve the DX of this tool.
templates/
to JSON configurations inconfigs/
, this'll make it easier to edit and parse (See fix(properties): allow quote-less props #185 for an example of dotenv struggles)--dry-run
argument, as, when testing this, it's important not to create the issues and notesnpx
-style support. (i.e.npx . tsc
ornpx https://github.com/nodejs/create-node-meeting-artifacts tsc
src/
, since it no longer really needs to be easily accessible for scripts, it'll benpx
-ed.The goal here is:
For example, running
npx . web --dry-run
produces: