Update node.js v12.6.0 to v12.7.0 with Yarn v1.17.3 #1063
Conversation
PeterDaveHello
commented
Jul 24, 2019
PeterDaveHello
commented
- https://nodejs.org/en/blog/release/v12.7.0/
- https://github.com/nodejs/node/releases/tag/v12.7.0
- https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#12.7.0
| @@ -1,6 +1,6 @@ | |||
| FROM alpine:3.9 | |||
There was a problem hiding this comment.
Should this also bump to 3.10?
There was a problem hiding this comment.
We haven't bump the version in config, so I don't think so.
There was a problem hiding this comment.
It should, unless we've changed our policy
There was a problem hiding this comment.
Debian Buster was also released but not changed in the config yet, I suggest not to block nodejs release process.
There was a problem hiding this comment.
We get grief everytime we change os versions. I think the way we handle debian now is pretty solid so it isn't an issue anymore but until we use multiple versions of alpine, the switching version is going to be an issue.
|
Just to make sure, we wanna deliver it with new Debian and Alpine or not? |
|
Debian can land regardless (that's a new variant), but I think alpine should land |
|
As there is no PR for it, yet, I prefer to merge this right now. @chorrell @LaurentGoderre what do you guys think? |
|
I would prefer to merge this now because we aren't ready enough for a major OS change in Alpine. This one should also get Buster because I merged it before this one. |
PeterDaveHello
force-pushed
the
update-node.js
branch
from
b526779 to
c80a296
Compare
|
@PeterDaveHello Please note that now buster images are still node.js v12.6.0 with these changes in master. |
|
Created PR to the official-images repo (docker-library/official-images#6356) |
