Don't use a default variant in the repo (ony in stackbrew) #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The stackbrew creates this after the change |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Mind creating a diff against master and pasting that? |
|
The diff: diff --git i/pr w/pr
index 5c4a063..a7ec48b 100644
--- i/pr
+++ w/pr
@@ -1,12 +1,12 @@
-# this file is generated via https://github.com/nodejs/docker-node/blob/c3baf8491ef0967ac32ee7b20afc66a32e2c4c73/generate-stackbrew-library.sh
+# this file is generated via https://github.com/nodejs/docker-node/blob/64eed01a95c5672ee9426e5e6be19a39b178a103/generate-stackbrew-library.sh
Maintainers: The Node.js Docker Team <https://github.com/nodejs/docker-node> (@nodejs)
GitRepo: https://github.com/nodejs/docker-node.git
-Tags: 9.11.1, 9.11, 9
+Tags: 9.11.1-jessie, 9.11-jessie, 9-jessie, 9.11.1, 9.11, 9
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
-GitCommit: 9023f588717d236a92d91a8483ff0582484c22d1
-Directory: 9
+GitCommit: 64eed01a95c5672ee9426e5e6be19a39b178a103
+Directory: 9/jessie
Tags: 9.11.1-alpine, 9.11-alpine, 9-alpine
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6, i386
@@ -33,10 +33,10 @@ Architectures: amd64
GitCommit: 9023f588717d236a92d91a8483ff0582484c22d1
Directory: 9/wheezy
-Tags: 8.11.1, 8.11, 8, carbon
+Tags: 8.11.1-jessie, 8.11-jessie, 8-jessie, carbon-jessie, 8.11.1, 8.11, 8, carbon
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
-GitCommit: b3ca6573b5c179148b446107386ae96ac6204ad3
-Directory: 8
+GitCommit: 64eed01a95c5672ee9426e5e6be19a39b178a103
+Directory: 8/jessie
Tags: 8.11.1-alpine, 8.11-alpine, 8-alpine, carbon-alpine
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6, i386
@@ -63,10 +63,10 @@ Architectures: amd64
GitCommit: b3ca6573b5c179148b446107386ae96ac6204ad3
Directory: 8/wheezy
-Tags: 6.14.2, 6.14, 6, boron
+Tags: 6.14.2-jessie, 6.14-jessie, 6-jessie, boron-jessie, 6.14.2, 6.14, 6, boron
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
-GitCommit: bb49c321f761c333ba87b18770121651f0a3004c
-Directory: 6
+GitCommit: 64eed01a95c5672ee9426e5e6be19a39b178a103
+Directory: 6/jessie
Tags: 6.14.2-alpine, 6.14-alpine, 6-alpine, boron-alpine
Architectures: amd64
@@ -93,10 +93,10 @@ Architectures: amd64
GitCommit: bb49c321f761c333ba87b18770121651f0a3004c
Directory: 6/wheezy
-Tags: 4.9.1, 4.9, 4, argon
+Tags: 4.9.1-jessie, 4.9-jessie, 4-jessie, argon-jessie, 4.9.1, 4.9, 4, argon
Architectures: amd64, ppc64le, arm64v8, arm32v7, i386
-GitCommit: f56c21260109ad432ec3ea5ba96dbd3b9daa4ea7
-Directory: 4
+GitCommit: 64eed01a95c5672ee9426e5e6be19a39b178a103
+Directory: 4/jessie
Tags: 4.9.1-alpine, 4.9-alpine, 4-alpine, argon-alpine
Architectures: amd64
@@ -123,10 +123,10 @@ Architectures: amd64
GitCommit: f56c21260109ad432ec3ea5ba96dbd3b9daa4ea7
Directory: 4/wheezy
-Tags: 10.0.0, 10.0, 10, latest
+Tags: 10.0.0-jessie, 10.0-jessie, 10-jessie, jessie, 10.0.0, 10.0, 10, latest
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
-GitCommit: 80814e984e9faa5e9195f9a61632e1898f6633d9
-Directory: 10
+GitCommit: 64eed01a95c5672ee9426e5e6be19a39b178a103
+Directory: 10/jessie
Tags: 10.0.0-alpine, 10.0-alpine, 10-alpine, alpine
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6, i386The I like having |
|
The directory is good, there is no longer a root Dockerfile, they are all in subdirs |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Ah, I missed the renames! |
|
@PeterDaveHello @SimenB are you guys ok with this? |
|
@tianon is this also consistent with other official images? |
|
@SimenB here is the diff of changing the default variant from jessie to stretch |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
What's the benefit of moving the default |
|
@chorrell first I think it's useful to have the |
LaurentGoderre
force-pushed
the
no-default-variant
branch
3 times, most recently
from
ff46be7 to
1c970ff
Compare
|
I think this is ready to go. @chorrell what do you think? |
|
Sure |
|
@chorrell you don't sound convince. What makes you unsure about it? |
|
It's a useful change, but I don't see it as being urgent. There's been a lot of recent changes, specifically with the update and PR process, and I'd prefer if we waited until after a few Node.js updates before landing anything new. |
|
That's a valid point! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
LaurentGoderre
force-pushed
the
no-default-variant
branch
4 times, most recently
from
6991fdb to
8acf726
Compare
|
I didn't apply that logic to chakracore because it doesn't have variants yet. |
|
No, that's not what I mean. That's all the output I get from |
|
Oh really....something might have got lost in all the rebasing |
LaurentGoderre
force-pushed
the
no-default-variant
branch
from
0a3c3d3 to
eef95e0
Compare
|
@chorrell fixed! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
LaurentGoderre
force-pushed
the
no-default-variant
branch
6 times, most recently
from
da05898 to
db7f5bb
Compare
|
All done! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
LaurentGoderre
force-pushed
the
no-default-variant
branch
4 times, most recently
from
7b02f20 to
730c97a
Compare
|
Ok, I rebased and cleaned up this PR |
LaurentGoderre
force-pushed
the
no-default-variant
branch
from
730c97a to
83d86a2
Compare
|
Ok, rebased |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Explicitly define the debian version to use for onbuild
LaurentGoderre
force-pushed
the
no-default-variant
branch
from
83d86a2 to
11a62b6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.