Skip the images build when no images changed #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

PeterDaveHello merged 2 commits into nodejs:master from LaurentGoderre:implement-743

May 29, 2018

Member

LaurentGoderre commented May 17, 2018

Implements #743

LaurentGoderre requested review from PeterDaveHello, SimenB and chorrell and removed request for PeterDaveHello and SimenB

May 17, 2018 19:24

This comment was marked as off-topic.

Sign in to view

LaurentGoderre force-pushed the implement-743 branch 3 times, most recently from 5f03b27 to 1a70aa9 Compare

May 18, 2018 15:30

This comment was marked as off-topic.

Sign in to view

Member Author

LaurentGoderre commented May 18, 2018

Hmmmm, that is a weakness......

LaurentGoderre force-pushed the implement-743 branch from 1a70aa9 to d42b2f2 Compare

May 18, 2018 18:44

This comment was marked as off-topic.

Sign in to view

LaurentGoderre force-pushed the implement-743 branch from d42b2f2 to b2db046 Compare

May 18, 2018 18:55

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

LaurentGoderre force-pushed the implement-743 branch 3 times, most recently from c4bde4c to c875cba Compare

May 22, 2018 19:40

This comment was marked as off-topic.

Sign in to view

LaurentGoderre force-pushed the implement-743 branch from c875cba to 7113847 Compare

May 22, 2018 20:07

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

LaurentGoderre force-pushed the implement-743 branch 2 times, most recently from 1823c97 to 0f1d286 Compare

May 24, 2018 07:10

Member

PeterDaveHello commented May 24, 2018

Should get this merged to save CI resource and all of our time ;)

Member

PeterDaveHello commented May 24, 2018

@LaurentGoderre let's fix the conflicts? Thanks.

LaurentGoderre force-pushed the implement-743 branch from 0f1d286 to 17fab14 Compare

May 25, 2018 15:45

LaurentGoderre force-pushed the implement-743 branch from 17fab14 to f425f7d Compare

May 25, 2018 17:18

Member Author

LaurentGoderre commented May 25, 2018

Fixed the conflict. Please re-review because some stuff changed.

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

LaurentGoderre force-pushed the implement-743 branch 3 times, most recently from 4d98b2c to 4c369ab Compare

May 28, 2018 02:33

This comment was marked as off-topic.

Sign in to view

LaurentGoderre added 2 commits

May 28, 2018 00:08


          Skip the images build when no images changed

aad561a

Implements nodejs#743


          Speed up the skipping of the build

bffff57

LaurentGoderre force-pushed the implement-743 branch from 4c369ab to bffff57 Compare

May 28, 2018 04:08

Member Author

LaurentGoderre commented May 28, 2018

@PeterDaveHello are we good?

This comment was marked as off-topic.

Sign in to view

PeterDaveHello merged commit 40fd374 into nodejs:master

LaurentGoderre deleted the implement-743 branch

May 29, 2018 14:24

Contributor

chorrell commented May 31, 2018

I think there are some problems with this. My branch should be running the image builds, but it's not:

https://travis-ci.org/nodejs/docker-node/builds/385982634

Note the errors here:

https://travis-ci.org/nodejs/docker-node/jobs/385982641#L465

fatal: ambiguous argument '49089bd3be1f...e5cebee5dbf9': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument '49089bd3be1f...e5cebee5dbf9': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

PeterDaveHello mentioned this pull request

Adjust $TRAVIS_COMMIT_RANGE for git #766

Merged

Member

PeterDaveHello commented May 31, 2018

@chorrell I got the point, git uses .. but Travis CI uses ...

Member

PeterDaveHello commented May 31, 2018

@LaurentGoderre I suppose the function should fail Travis CI but didn't?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet