Skip to content

node land thinks a PR with failed build is landable #377

@sam-github

Description

@sam-github

output from node-core-utils master here: nodejs/node#30637 (comment)

It correctly found the ci commit message, and the commit, but doesn't seem to evaluate its pass/fail status.

I tried again with npm install on 10.x, same issue:

core/lts (master $% u=) % git node land https://github.com/nodejs/node/pull/30637
✔  Done loading data for nodejs/node/pull/30637
----------------------------------- PR info ------------------------------------
Title      tls: expose IETF name for current cipher suite (#30637)
Author     Sam Roberts <vieuxtech@gmail.com> (@sam-github)
Branch     sam-github:tls-standard-name -> nodejs:master
Labels     C++, crypto, semver-minor
Commits    1
 - tls: expose IETF name for current cipher suite
Committers 1
 - Sam Roberts <vieuxtech@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/30637
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  Last Full PR CI on 2019-11-27T23:21:35Z: https://ci.nodejs.org/job/node-test-pull-request/27056/
   ℹ  This PR was created on Mon, 25 Nov 2019 17:25:47 GMT
   ✔  Approvals: 8
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/30637#pullrequestreview-322484515
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/30637#pullrequestreview-322509526
   ✔  - David Carlier (@devnexen): https://github.com/nodejs/node/pull/30637#pullrequestreview-322823276
   ✔  - Yorkie Liu (@yorkie): https://github.com/nodejs/node/pull/30637#pullrequestreview-322831622
   ✔  - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/30637#pullrequestreview-322868042
   ✔  - Anna Henningsen (@addaleax) (TSC): https://github.com/nodejs/node/pull/30637#pullrequestreview-322989675
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/30637#pullrequestreview-323816567
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/30637#pullrequestreview-323925693
--------------------------------------------------------------------------------
? This PR should be ready to land, do you want to continue? (Y/n)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions