Sync error not helpful

[BridgeAR]

I just wanted to backport a PR and I got the following error:

$ git node backport 33490 --to 14
Error
    at exports.runSync (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/lib/run.js:60:11)
    at new Session (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/lib/session.js:28:26)
    at new BackportSession (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/lib/backport_session.js:18:5)
    at main (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/components/git/backport.js:48:19)
    at Object.handler (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/components/git/backport.js:66:21)
    at Object.runCommand (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/node_modules/yargs/lib/command.js:240:40)
    at Object.parseArgs [as _parseArgs] (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/node_modules/yargs/yargs.js:1154:41)
    at Object.get [as argv] (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/node_modules/yargs/yargs.js:1088:21)
    at Object.<anonymous> (/home/ruben/.nvm/versions/node/v14.2.0/lib/node_modules/node-core-utils/bin/git-node:20:3)
    at Module._compile (internal/modules/cjs/loader.js:1176:30)

We should probably include stdout as well and maybe there's more to improve the error somewhere else as well.

[codebytere]

@BridgeAR this was fixed in #426 - it just hasn't been published yet :)

you'll now see:

node-core-utils on git:master ❯ git node backport 33490 --to 14               12:43PM
⚠  You have not told git-node what branch you are trying to land commits on.
--------------------------------------------------------------------------------
ℹ  For example, if your want to land commits on the `master` branch, you can run:

  $ ncu-config set branch master
--------------------------------------------------------------------------------
⚠  You have not told git-node the remote you want to sync with.
--------------------------------------------------------------------------------
ℹ  For example, if your remote pointing to nodejs/node is `remote-upstream`, you can run:

  $ ncu-config set upstream remote-upstream
--------------------------------------------------------------------------------
Error: Failed to create new session
    at new Session (/Users/codebytere/Developer/node-core-utils/lib/session.js:29:13)
    at new BackportSession (/Users/codebytere/Developer/node-core-utils/lib/backport_session.js:18:5)
    at main (/Users/codebytere/Developer/node-core-utils/components/git/backport.js:48:19)
    at Object.handler (/Users/codebytere/Developer/node-core-utils/components/git/backport.js:66:21)
    at Object.runCommand (/Users/codebytere/Developer/node-core-utils/node_modules/yargs/lib/command.js:240:40)
    at Object.parseArgs [as _parseArgs] (/Users/codebytere/Developer/node-core-utils/node_modules/yargs/yargs.js:1154:41)
    at Object.get [as argv] (/Users/codebytere/Developer/node-core-utils/node_modules/yargs/yargs.js:1088:21)
    at Object.<anonymous> (/Users/codebytere/Developer/node-core-utils/bin/git-node:20:3)
    at Module._compile (internal/modules/cjs/loader.js:1176:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10)

[BridgeAR]

Awesome! Should we maybe also include a hint how to fix that?

[gengjiawen]

Any new release on schedule ? running into same issue.

[gengjiawen]

With master looks like still exists:

root@localhost ~/node (master)# git node land 33975
Error
    at exports.runSync (/usr/local/lib/node_modules/node-core-utils/lib/run.js:60:11)
    at new Session (/usr/local/lib/node_modules/node-core-utils/lib/session.js:32:26)
    at new LandingSession (/usr/local/lib/node_modules/node-core-utils/lib/landing_session.js:19:5)
    at main (/usr/local/lib/node_modules/node-core-utils/components/git/land.js:131:17)
    at land (/usr/local/lib/node_modules/node-core-utils/components/git/land.js:114:21)
    at Object.handler (/usr/local/lib/node_modules/node-core-utils/components/git/land.js:78:14)
    at Object.runCommand (/usr/local/lib/node_modules/node-core-utils/node_modules/yargs/lib/command.js:240:40)
    at Object.parseArgs [as _parseArgs] (/usr/local/lib/node_modules/node-core-utils/node_modules/yargs/yargs.js:1154:41)
    at Object.get [as argv] (/usr/local/lib/node_modules/node-core-utils/node_modules/yargs/yargs.js:1088:21)
    at Object.<anonymous> (/usr/local/lib/node_modules/node-core-utils/bin/git-node:20:3)

Update:
With following patch

    console.warn(child.status);
    console.warn(child.stderr.toString());
    console.warn(child.stdout.toString());
    throw new Error(child.stderr.toString());

got

1


Error
    at exports.runSync (/usr/local/lib/node_modules/node-core-utils/lib/run.js:63:11)

Env:

  System:
    OS: Linux 5.4 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (1) x64 Intel(R) Xeon(R) CPU E5-2697 v4 @ 2.30GHz
    Memory: 155.83 MB / 981.22 MB
    Container: Yes
    Shell: 3.1.0 - /usr/bin/fish
  Binaries:
    Node: 14.4.0 - /usr/local/bin/node
    npm: 6.14.5 - /usr/local/bin/npm
  Managers:
    Apt: 2.0.2 - /usr/bin/apt
  Utilities:
    Make: 4.2.1 - /usr/bin/make
    GCC: 9.3.0 - /usr/bin/gcc
    Git: 2.27.0 - /usr/bin/git
  Virtualization:
    Docker: 19.03.8 - /usr/bin/docker
  IDEs:
    Nano: 4.8 - /usr/bin/nano
    Vim: 8.1 - /usr/bin/vim
  Languages:
    Bash: 5.0.16 - /usr/bin/bash
    Perl: 5.30.0 - /usr/bin/perl
    Python3: 3.8.2 - /usr/bin/pyth

[gengjiawen]

My root cause is I misconfig upstream. The raw git command git config --get just return 1 with no stderr and stdout.

[codebytere]

Closing as resolved by #426