fix: use case-insensitive string comparison for fast-track approvals #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed today that a PR that had sufficient fast-track approvals was being rejected as needing one more approval. This is because one of the approvers' had a GitHub handle where the case in the README (`linkgoron`) did not match the case returned by GitHub (`Linkgoron`). Since GitHub handles are case-insensitive, this change makes the comparison case-insensitive. One might be tempted to think that we need to do the same for the list of TSC members, but handles are never compared there so it is not necessary.
Codecov ReportBase: 83.60% // Head: 83.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 37 37
Lines 4117 4117
=======================================
Hits 3442 3442
Misses 675 675
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
targos
approved these changes
Nov 8, 2022
codebytere
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed today that a PR that had sufficient fast-track approvals was being rejected as needing one more approval. This is because one of the approvers' had a GitHub handle where the case in the README (
linkgoron) did not match the case returned by GitHub (Linkgoron). Since GitHub handles are case-insensitive, this change makes the comparison case-insensitive.One might be tempted to think that we need to do the same for the list of TSC members, but handles are never compared there so it is not necessary.