Skip to content

fix: define a fallback editor #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2024
Merged

fix: define a fallback editor #802

merged 1 commit into from
May 11, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 29, 2024

Fixes: #605

@aduh95 aduh95 requested a review from targos April 29, 2024 20:56
@richardlau richardlau mentioned this pull request Apr 30, 2024
Merged
@targos targos merged commit 86e61f4 into nodejs:main May 11, 2024
@github-actions github-actions bot mentioned this pull request May 11, 2024
Merged
@aduh95 aduh95 deleted the fallback-editor branch May 11, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement fallback in case no EDITOR is set
5 participants
@aduh95 @anonrig @targos @richardlau @MoLow