fix: LTS release commit should contain codename #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Apr 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
=======================================
Coverage 76.28% 76.28%
=======================================
Files 21 21
Lines 1480 1480
=======================================
Hits 1129 1129
Misses 351 351 Continue to review full report at Codecov.
|
richardlau
approved these changes
Apr 9, 2020
BethGriggs
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated release commit for LTS releases should contain the codename.
Previously, this was the auto-generated output for an LTS release commit:
when it should be:
This fixes that issue.
cc @nodejs/releasers