Skip to content

fix: correct for new execGitNode syntax #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2020
Merged

fix: correct for new execGitNode syntax #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/update-v8/commitUpdate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = function() {
title: 'Commit V8 update',
task: async(ctx) => {
const newV8Version = util.getNodeV8Version(ctx.nodeDir).join('.');
await ctx.execGitNode('add', 'deps/v8');
await ctx.execGitNode('add', ['deps/v8']);
const moreArgs = [];
let message;
if (ctx.minor) {
Expand All @@ -21,7 +21,7 @@ module.exports = function() {
} else {
message = `deps: update V8 to ${newV8Version}`;
}
await ctx.execGitNode('commit', '-m', message, ...moreArgs);
await ctx.execGitNode('commit', ['-m', message, ...moreArgs]);
},
skip: (ctx) => ctx.skipped
};
Expand Down
18 changes: 9 additions & 9 deletions lib/update-v8/updateVersionNumbers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,16 @@ function bumpNodeModule() {
await updateModuleVersion(ctx.nodeDir, newModuleVersion, v8Version);
await ctx.execGitNode(
'add',
'doc/abi_version_registry.json',
'src/node_version.h'
['doc/abi_version_registry.json', 'src/node_version.h']
);
await ctx.execGitNode(
'commit',
'-m',
getCommitTitle(newModuleVersion),
'-m',
getCommitBody(v8Version)
[
'-m',
getCommitTitle(newModuleVersion),
'-m',
getCommitBody(v8Version)
]
);
},
skip: (ctx) => !ctx.versionBump
Expand Down Expand Up @@ -103,11 +104,10 @@ function resetEmbedderString() {
commonGypiPath,
commonGypi.replace(embedderRegex, embedderString)
);
await ctx.execGitNode('add', 'common.gypi');
await ctx.execGitNode('add', ['common.gypi']);
await ctx.execGitNode(
'commit',
'-m',
'build: reset embedder string to "-node.0"'
['-m', 'build: reset embedder string to "-node.0"']
);
} else {
return task.skip('Embedder version is already 0');
Expand Down