feat: set error code in some failure cases #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
- Coverage 77.13% 77.08% -0.06%
==========================================
Files 21 21
Lines 1496 1497 +1
==========================================
Hits 1154 1154
- Misses 342 343 +1
Continue to review full report at Codecov.
|
codebytere
reviewed
Jun 27, 2020
Adds an method to `cli` to set the process exit code, and use that method on some known failure situations (missing config and `git node land` failed checks). There are still more places where we should set exit code. Ref: nodejs#442
mmarchini
force-pushed
the
set-error-code
branch
from
f3b30dd to
c3187e9
Compare
codebytere
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an method to
clito set the process exit code, and use thatmethod on some known failure situations (missing config and
git node landfailed checks). There are still more places where we should set exit
code.
Ref: #442