Skip to content

fix: landing when no Jenkins CI has been run for PR #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix: landing when no Jenkins CI has been run for PR #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/ci/ci_result_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class Job {

async getBuildData() {
const { cli, path } = this;
cli.startSpinner(`Querying data of ${path}`);
cli.startSpinner(`Querying data for ${path}`);
const data = await this.getAPIData();
cli.stopSpinner('Build data downloaded');
return data;
Expand Down Expand Up @@ -679,6 +679,18 @@ class PRBuild extends TestBuild {
const {
result, subBuilds, changeSet, actions, timestamp
} = data;

// No builds found.
if (data.status === '404') {
const failure = new BuildFailure(this, 'No builds found for PR');
this.failures = [failure];
return {
result: data.result,
builds: { failed: [], aborted: [], pending: [], unstable: [] },
failures: this.failures
};
}

this.setBuildData(data);

// No sub build at all
Expand Down