Skip to content

fix: ensure node-test-commit job id in daily-master #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2020
Merged

fix: ensure node-test-commit job id in daily-master #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b379a
fix: get node-test-commit job id
codebytere Jul 20, 2020
5d14b02
chore: remove unused setDailyBuildData
codebytere Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions bin/ncu-ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,15 @@ class CICommand {
case DAILY_MASTER: {
const daily = new DailyBuild(cli, request, job.jobid);
const data = await daily.getBuildData();
build = new CommitBuild(cli, request, data.subBuilds[0].buildNumber);
break;
const testCommitBuild = data.subBuilds.filter(subBuild => {
return subBuild.jobName === 'node-test-commit';
})[0];
if (testCommitBuild) {
build = new CommitBuild(cli, request, testCommitBuild.buildNumber);
break;
} else {
throw new Error('Could not find \'node-test-commit\' job');
}
}
default:
throw new Error(`Unknown job type ${job.type}`);
Expand Down
7 changes: 0 additions & 7 deletions lib/ci/ci_result_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,6 @@ class TestBuild extends Job {
this.builtOn = builtOn;
}

setDailyBuildData({ result, changeSet, actions, timestamp, builtOn }) {
this.change = changeSet.items[0] || {};
this.date = new Date(timestamp);
this.result = result;
this.builtOn = builtOn;
}

get sourceURL() {
const { params } = this;

Expand Down