Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Fix use of deprecated methods removed in V8 7.0 #119

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Fix use of deprecated methods removed in V8 7.0 #119

merged 1 commit into from
Jan 22, 2019

Conversation

richardlau
Copy link
Member

StackFrame::GetFrame(uint32_t index) was deprecated in V8 6.9 and
removed in V8 7.0.

Refs: nodejs/node#22531

This fixes the errors compiling against the current Node.js master
(12.0.0-pre) that originate in this project. Resolving other compilation
errors require nan to release a fix containing nodejs/nan#831.

Refs: #116

@richardlau richardlau mentioned this pull request Dec 21, 2018
Closed
@richardlau
Copy link
Member Author

Note that the replacement function StackFrame::GetFrame(Isolate* isolate, uint32_t index) was backported to Node.js 10 in nodejs/node#22531 but it's only there in Node.js 10.10.0 and later so we continue to use the deprecated function to allow compilation on Node.js 10.9.0 and earlier.

mhdawson
mhdawson approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
Fix use of deprecated methods removed in V8 7.0
26f88d0 
StackFrame::GetFrame(uint32_t index) was deprecated in V8 6.9 and
removed in V8 7.0.

PR-URL: nodejs#119
Refs: nodejs/node#22531
Refs: nodejs#116
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@richardlau
Copy link
Member Author

richardlau commented Jan 22, 2019 •
edited
Loading

CI against Node.js 6: https://ci.nodejs.org/job/nodereport-continuous-integration/262/ ✔️

CI against Node.js 8: https://ci.nodejs.org/job/nodereport-continuous-integration/263/ ✔️

CI against Node.js 10: https://ci.nodejs.org/job/nodereport-continuous-integration/261/ ✔️

CI against Node.js 11: https://ci.nodejs.org/job/nodereport-continuous-integration/260/
currently broken due to nodejs/node#24861 (comment) but compilation succeeds without warnings about deprecated methods.

@richardlau richardlau merged commit 26f88d0 into nodejs:master Jan 22, 2019
richardlau added a commit to richardlau/nodereport that referenced this pull request Mar 15, 2019
@richardlau
Fix use of deprecated methods removed in V8 7.0
5e1e97d 
StackFrame::GetFrame(uint32_t index) was deprecated in V8 6.9 and
removed in V8 7.0.

Missed a Windows only instance in 26f88d0.

Refs: nodejs#119
@richardlau richardlau mentioned this pull request Mar 15, 2019
Merged
richardlau added a commit to richardlau/nodereport that referenced this pull request Mar 17, 2019
@richardlau
Fix use of deprecated methods removed in V8 7.0
734addf 
StackFrame::GetFrame(uint32_t index) was deprecated in V8 6.9 and
removed in V8 7.0.

Missed a Windows only instance in 26f88d0.

Refs: nodejs#119

PR-URL: nodejs#124
Refs: nodejs#119
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardlau @mhdawson