Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

improve child node process debugging #5012

Closed
segrey opened this issue Mar 14, 2013 · 2 comments
Closed

improve child node process debugging #5012

segrey opened this issue Mar 14, 2013 · 2 comments

Comments

@segrey
Copy link

segrey commented Mar 14, 2013

Spawning child node process is extremely useful to utilize CPU processors.
At the moment, it's necessary to check whether parent node process is running in debug mode. If yes a free port is found and --debug=<free port>`` or--debug-brk=<free port>are added to arguments of`child_process.spawn``` method. As the child process is spawned, it's necessary to attach debugger to the child process (unfortunately, this step requires manual work and amount of this work depends on the spawned child node process count).

Is it possible to improve the situation in Node.js core itself?
Ideally, whenever child node process is spawned by parent node process that is in debug mode, an IDE/node-inspector suggests you to start debugging it.
Ideas?

As a possible solution child_process.spawn could invoke callback JavaScript function isNodeChildProcessInDebugMode() that returns boolean (true means it's necessary to add --debug=<port> or --debug-brk=<port> parameter. And the second callback function is nodeChildProcessSpawnedOn(port) that is called as child node process is already spawned.
These callback functions could be implemented in child_node_process_spawn_listener.js.
In this case Node.js app could be started like this:
$ node --child_node_process_spawn_listener=/path/to/child_node_process_spawn_listener.js app.js

Thanks!

@jasnell
Copy link
Member

jasnell commented Jun 24, 2015

@segrey ... is this still something you're interested in pursuing?

@segrey
Copy link
Author

segrey commented Jun 24, 2015

@jasnell Nope, no need in this issue anymore.

@segrey segrey closed this as completed Jun 24, 2015
richardlau pushed a commit to ibmruntimes/node that referenced this issue Feb 29, 2016
* buffer:
  - You can now supply an encoding argument when filling a
    Buffer Buffer#fill(string[, start[, end]][, encoding]), supplying
    an existing Buffer will also work with
    Buffer#fill(buffer[, start[, end]]). See the API documentation for
    details on how this works. (Trevor Norris) nodejs#4935
  - Buffer#indexOf() no longer requires a byteOffset argument if you
    also wish to specify an encoding:
    Buffer#indexOf(val[, byteOffset][, encoding]).
    (Trevor Norris) nodejs#4803
* child_process: spawn() and spawnSync() now support a 'shell' option
  to allow for optional execution of the given command inside a shell.
  If set to true, cmd.exe will be used on Windows and /bin/sh
  elsewhere. A path to a custom shell can also be passed to override
  these defaults. On Windows, this option allows .bat. and .cmd files
  to be executed with spawn() and spawnSync(). (Colin Ihrig) nodejs#4598
* http_parser: Update to http-parser 2.6.2 to fix an unintentionally
  strict limitation of allowable header characters.
  (James M Snell) nodejs#5237
* dgram: socket.send() now supports accepts an array of Buffers or
  Strings as the first argument. See the API docs for details on how
  this works. (Matteo Collina) nodejs#4374
* http: Fix a bug where handling headers will mistakenly trigger an
  'upgrade' event where the server is just advertising its protocols.
  This bug can prevent HTTP clients from communicating with HTTP/2
  enabled servers. (Fedor Indutny) nodejs#4337
* net: Added a listening Boolean property to net and http servers to
  indicate whether the server is listening for connections.
  (José Moreira) nodejs#4743
* node: The C++ node::MakeCallback() API is now reentrant and calling
  it from inside another MakeCallback() call no longer causes the
  nextTick queue or Promises microtask queue to be processed out of
  order. (Trevor Norris) nodejs#4507
* tls: Add a new tlsSocket.getProtocol() method to get the negotiated
  TLS protocol version of the current connection. (Brian White) nodejs#4995
* vm: Introduce new 'produceCachedData' and 'cachedData' options to
  new vm.Script() to interact with V8's code cache. When a new
  vm.Script object is created with the 'produceCachedData' set to true
  a Buffer with V8's code cache data will be produced and stored in
  cachedData property of the returned object. This data in turn may be
  supplied back to another vm.Script() object with a 'cachedData'
  option if the supplied source is the same. Successfully executing a
  script from cached data can speed up instantiation time. See the API
  docs for details. (Fedor Indutny) nodejs#4777
* performance: Improvements in:
  - process.nextTick() (Ruben Bridgewater) nodejs#5092
  - path module (Brian White) nodejs#5123
  - querystring module (Brian White) nodejs#5012
  - streams module when processing small chunks (Matteo Collina) nodejs#4354

PR-URL: nodejs/node#5295
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants