assert: manutally create stack trace message

[trevnorris]

v8 has changed how it generates it's messages, so as a fix the stack is
manually manipulated after to properly display the assert message text.

This change is absolute crap, and I don't like manipulating the stack trace string this way. But so far it's the only way I've figured out how to do it. Will look for a better way for a little longer, but go ahead and use this if you want.

[trevnorris]

hold off. found a better way. going to amend

[trevnorris]

nope. not going to spend more time on this.

[isaacs]

What about something like this?

diff --git a/lib/assert.js b/lib/assert.js
index a2afdcf..d19b163 100644
--- a/lib/assert.js
+++ b/lib/assert.js
@@ -45,9 +45,9 @@ assert.AssertionError = function AssertionError(options) {
   this.operator = options.operator;
   var stackStartFunction = options.stackStartFunction || fail;

-  if (Error.captureStackTrace) {
-    Error.captureStackTrace(this, stackStartFunction);
-  }
+  this.name = this.toString();
+  this.toString = Error.prototype.toString;
+  Error.captureStackTrace(this, stackStartFunction);
 };

 // assert.AssertionError instanceof Error

[trevnorris]

You'll have to revert the DEBUG message manipulation I did in fs.js. For
extra safety might not want to set .message at all and instead make the
toString a static call to which you pass the instance and the message.

But nice solution. Had tried something similar with setting the message
manually, but could never get it consistent.

[isaacs]

Fixed on 4716dc6