Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

--throw-deprecation, fewer nextTick calls in Writable #4930

Closed
wants to merge 3 commits into from

Conversation

isaacs
Copy link

@isaacs isaacs commented Mar 6, 2013

@tjfontaine noticed that a huge amount of nextTick recursion errors were showing up in pummel/test-regress-GH-892. Since the last refactor to the Writable logic, this was also causing a range error. (The warnings had previously been in Readable, but the refactor moved the warning to Writable.write, which triggered a console.error, which calls process.stderr.write, aka Socket.write, etc.)

The first commit adds --throw-deprecation. This flag was very helpful in tracking down the recursion warning. --trace-deprecation was not so helpful, since the recursive nature of the warning caused a range error and blew up the output. It's often good to stop on the first deprecation, print a stack, and quit.

The second commit adds execArgv to the arguments passed to the child proc in pummel/test-regress-GH-892.

The third fixes the actual bug.

@bnoordhuis
Copy link
Member

Partial duplicate of #4934?

@isaacs
Copy link
Author

isaacs commented Mar 6, 2013

#4934 is just a branch that's on top of this one. I'll update them both.

@isaacs
Copy link
Author

isaacs commented Mar 6, 2013

Updated with comment.

@isaacs
Copy link
Author

isaacs commented Mar 6, 2013

Taking it over to #4934

@isaacs isaacs closed this Mar 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants