This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
--throw-deprecation, fewer nextTick calls in Writable #4930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tjfontaine noticed that a huge amount of nextTick recursion errors were showing up in pummel/test-regress-GH-892. Since the last refactor to the Writable logic, this was also causing a range error. (The warnings had previously been in Readable, but the refactor moved the warning to Writable.write, which triggered a console.error, which calls process.stderr.write, aka Socket.write, etc.)
The first commit adds
--throw-deprecation
. This flag was very helpful in tracking down the recursion warning.--trace-deprecation
was not so helpful, since the recursive nature of the warning caused a range error and blew up the output. It's often good to stop on the first deprecation, print a stack, and quit.The second commit adds
execArgv
to the arguments passed to the child proc in pummel/test-regress-GH-892.The third fixes the actual bug.