This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Stream readable last 0.10 fixes #4934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few? |
Extremely handy when tracking down a flood of recursive nextTick warnings.
If the consumer of a Readable is asking for N bytes, and N > hwm, then clearly we have set the hwm to low, and ought to increase it. Fix nodejs#4931
It's not actually necessary for backwards compatibility, isn't used anywhere, and isn't even tested. Better to just remove it.
Now that highWaterMark increases when there are large reads, this greatly reduces the number of calls necessary to _read(size), assuming that _read actually respects the size argument.
| @@ -162,6 +161,18 @@ Readable.prototype.setEncoding = function(enc) { | |||
| this._readableState.decoder = new StringDecoder(enc); | |||
| }; | |||
|
|
|||
| var MAX_HWM = Math.pow(2, 30) - 1; | |||
| function raiseHWM(n) { | |||
There was a problem hiding this comment.
Well, it's only raising it if it's smaller than the max. But sure, roundUpToNextPowerOf2 is fine.
This prevents excessively raising the buffer level in tiny increments in pathological cases.
|
LGTM! |
|
Landed on master. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few last fixes for Readable streams to get in before 0.10.
Sits on top of #4930. Just got tired of sending a separate PR for each commit.