Skip to content
Permalink
Browse files

deps: V8: cherry-pick 5b0510d

Original commit message:

    Give the implementation of v8::MicrotaskQueue::New

    This adds the entrypoint to MicrotaskQueue, which used to miss the
    implementation.

    Bug: v8:8124
    Change-Id: I114fb69d975ee75c86b19349ca76789e425ea910
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505232
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60076}

Refs: v8/v8@5b0510d

PR-URL: #26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information...
addaleax authored and refack committed Mar 15, 2019
1 parent bf572c7 commit 02171949a02fb55adfeeaec90a3fc9be1c1d2bd3
Showing with 7 additions and 2 deletions.
  1. +1 −1 common.gypi
  2. +1 −1 deps/v8/include/v8.h
  3. +5 −0 deps/v8/src/api.cc
@@ -37,7 +37,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.3',
'v8_embedder_string': '-node.4',

##### V8 defaults for Node.js #####

@@ -6779,7 +6779,7 @@ class V8_EXPORT MicrotaskQueue {
/**
* Creates an empty MicrotaskQueue instance.
*/
static std::unique_ptr<MicrotaskQueue> New();
static std::unique_ptr<MicrotaskQueue> New(Isolate* isolate);

virtual ~MicrotaskQueue() = default;

@@ -8931,6 +8931,11 @@ void v8::Isolate::LocaleConfigurationChangeNotification() {
#endif // V8_INTL_SUPPORT
}

// static
std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate) {
return i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));
}

MicrotasksScope::MicrotasksScope(Isolate* isolate, MicrotasksScope::Type type)
: MicrotasksScope(
isolate,

0 comments on commit 0217194

Please sign in to comment.
You can’t perform that action at this time.