node-api: add missing initialization of last error

mhdawson · danielleadams · commit 03490cb311c1 · 2022-01-31T23:54:36.000-05:00
- Add missing initiatlization of last error which was reported by coverity. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41290 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
diff --git a/src/js_native_api_v8.h b/src/js_native_api_v8.h
@@ -56,6 +56,7 @@ struct napi_env__ {
       : isolate(context->GetIsolate()),
         context_persistent(isolate, context) {
     CHECK_EQ(isolate, context->GetIsolate());
+    napi_clear_last_error(this);
   }
   virtual ~napi_env__() {
     // First we must finalize those references that have `napi_finalizer`

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ struct napi_env__ {`
`56`	`56`	`: isolate(context->GetIsolate()),`
`57`	`57`	`context_persistent(isolate, context) {`
`58`	`58`	`CHECK_EQ(isolate, context->GetIsolate());`
	`59`	`+ napi_clear_last_error(this);`
`59`	`60`	`}`
`60`	`61`	`virtual ~napi_env__() {`
`61`	`62`	// First we must finalize those references that have `napi_finalizer`