Skip to content

Commit 05f7412

Browse files
jun-okaFishrock123
authored andcommitted
test: refactor assert in internet test-dns.js
change assert.equal() to assert.strictEqual() and use assert.strictEqual() for type validation PR-URL: #8980 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent b83f51a commit 05f7412

File tree

1 file changed

+42
-42
lines changed

1 file changed

+42
-42
lines changed

test/internet/test-dns.js

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ function TEST(f) {
3939

4040

4141
function checkWrap(req) {
42-
assert.ok(typeof req === 'object');
42+
assert.strictEqual(typeof req, 'object');
4343
}
4444

4545

@@ -70,12 +70,12 @@ TEST(function test_resolveMx(done) {
7070
for (var i = 0; i < result.length; i++) {
7171
var item = result[i];
7272
assert.ok(item);
73-
assert.ok(typeof item === 'object');
73+
assert.strictEqual(typeof item, 'object');
7474

7575
assert.ok(item.exchange);
76-
assert.ok(typeof item.exchange === 'string');
76+
assert.strictEqual(typeof item.exchange, 'string');
7777

78-
assert.ok(typeof item.priority === 'number');
78+
assert.strictEqual(typeof item.priority, 'number');
7979
}
8080

8181
done();
@@ -89,7 +89,7 @@ TEST(function test_resolveMx_failure(done) {
8989
assert.ok(err instanceof Error);
9090
assert.strictEqual(err.errno, 'ENOTFOUND');
9191

92-
assert.ok(result == undefined);
92+
assert.strictEqual(result, undefined);
9393

9494
done();
9595
});
@@ -106,7 +106,7 @@ TEST(function test_resolveNs(done) {
106106
for (var i = 0; i < names.length; i++) {
107107
var name = names[i];
108108
assert.ok(name);
109-
assert.ok(typeof name === 'string');
109+
assert.strictEqual(typeof name, 'string');
110110
}
111111

112112
done();
@@ -120,7 +120,7 @@ TEST(function test_resolveNs_failure(done) {
120120
assert.ok(err instanceof Error);
121121
assert.strictEqual(err.errno, 'ENOTFOUND');
122122

123-
assert.ok(result == undefined);
123+
assert.strictEqual(result, undefined);
124124

125125
done();
126126
});
@@ -137,14 +137,14 @@ TEST(function test_resolveSrv(done) {
137137
for (var i = 0; i < result.length; i++) {
138138
var item = result[i];
139139
assert.ok(item);
140-
assert.ok(typeof item === 'object');
140+
assert.strictEqual(typeof item, 'object');
141141

142142
assert.ok(item.name);
143-
assert.ok(typeof item.name === 'string');
143+
assert.strictEqual(typeof item.name, 'string');
144144

145-
assert.ok(typeof item.port === 'number');
146-
assert.ok(typeof item.priority === 'number');
147-
assert.ok(typeof item.weight === 'number');
145+
assert.strictEqual(typeof item.port, 'number');
146+
assert.strictEqual(typeof item.priority, 'number');
147+
assert.strictEqual(typeof item.weight, 'number');
148148
}
149149

150150
done();
@@ -158,7 +158,7 @@ TEST(function test_resolveSrv_failure(done) {
158158
assert.ok(err instanceof Error);
159159
assert.strictEqual(err.errno, 'ENOTFOUND');
160160

161-
assert.ok(result == undefined);
161+
assert.strictEqual(result, undefined);
162162

163163
done();
164164
});
@@ -175,7 +175,7 @@ TEST(function test_resolvePtr(done) {
175175
for (var i = 0; i < result.length; i++) {
176176
var item = result[i];
177177
assert.ok(item);
178-
assert.ok(typeof item === 'string');
178+
assert.strictEqual(typeof item, 'string');
179179
}
180180

181181
done();
@@ -189,7 +189,7 @@ TEST(function test_resolvePtr_failure(done) {
189189
assert.ok(err instanceof Error);
190190
assert.strictEqual(err.errno, 'ENOTFOUND');
191191

192-
assert.ok(result == undefined);
192+
assert.strictEqual(result, undefined);
193193

194194
done();
195195
});
@@ -206,14 +206,14 @@ TEST(function test_resolveNaptr(done) {
206206
for (var i = 0; i < result.length; i++) {
207207
var item = result[i];
208208
assert.ok(item);
209-
assert.ok(typeof item === 'object');
210-
211-
assert.ok(typeof item.flags === 'string');
212-
assert.ok(typeof item.service === 'string');
213-
assert.ok(typeof item.regexp === 'string');
214-
assert.ok(typeof item.replacement === 'string');
215-
assert.ok(typeof item.order === 'number');
216-
assert.ok(typeof item.preference === 'number');
209+
assert.strictEqual(typeof item, 'object');
210+
211+
assert.strictEqual(typeof item.flags, 'string');
212+
assert.strictEqual(typeof item.service, 'string');
213+
assert.strictEqual(typeof item.regexp, 'string');
214+
assert.strictEqual(typeof item.replacement, 'string');
215+
assert.strictEqual(typeof item.order, 'number');
216+
assert.strictEqual(typeof item.preference, 'number');
217217
}
218218

219219
done();
@@ -227,7 +227,7 @@ TEST(function test_resolveNaptr_failure(done) {
227227
assert.ok(err instanceof Error);
228228
assert.strictEqual(err.errno, 'ENOTFOUND');
229229

230-
assert.ok(result == undefined);
230+
assert.strictEqual(result, undefined);
231231

232232
done();
233233
});
@@ -240,27 +240,27 @@ TEST(function test_resolveSoa(done) {
240240
if (err) throw err;
241241

242242
assert.ok(result);
243-
assert.ok(typeof result === 'object');
243+
assert.strictEqual(typeof result, 'object');
244244

245-
assert.ok(typeof result.nsname === 'string');
245+
assert.strictEqual(typeof result.nsname, 'string');
246246
assert.ok(result.nsname.length > 0);
247247

248-
assert.ok(typeof result.hostmaster === 'string');
248+
assert.strictEqual(typeof result.hostmaster, 'string');
249249
assert.ok(result.hostmaster.length > 0);
250250

251-
assert.ok(typeof result.serial === 'number');
251+
assert.strictEqual(typeof result.serial, 'number');
252252
assert.ok((result.serial > 0) && (result.serial < 4294967295));
253253

254-
assert.ok(typeof result.refresh === 'number');
254+
assert.strictEqual(typeof result.refresh, 'number');
255255
assert.ok((result.refresh > 0) && (result.refresh < 2147483647));
256256

257-
assert.ok(typeof result.retry === 'number');
257+
assert.strictEqual(typeof result.retry, 'number');
258258
assert.ok((result.retry > 0) && (result.retry < 2147483647));
259259

260-
assert.ok(typeof result.expire === 'number');
260+
assert.strictEqual(typeof result.expire, 'number');
261261
assert.ok((result.expire > 0) && (result.expire < 2147483647));
262262

263-
assert.ok(typeof result.minttl === 'number');
263+
assert.strictEqual(typeof result.minttl, 'number');
264264
assert.ok((result.minttl >= 0) && (result.minttl < 2147483647));
265265

266266
done();
@@ -274,7 +274,7 @@ TEST(function test_resolveSoa_failure(done) {
274274
assert.ok(err instanceof Error);
275275
assert.strictEqual(err.errno, 'ENOTFOUND');
276276

277-
assert.ok(result == undefined);
277+
assert.strictEqual(result, undefined);
278278

279279
done();
280280
});
@@ -291,7 +291,7 @@ TEST(function test_resolveCname(done) {
291291
for (var i = 0; i < names.length; i++) {
292292
var name = names[i];
293293
assert.ok(name);
294-
assert.ok(typeof name === 'string');
294+
assert.strictEqual(typeof name, 'string');
295295
}
296296

297297
done();
@@ -305,7 +305,7 @@ TEST(function test_resolveCname_failure(done) {
305305
assert.ok(err instanceof Error);
306306
assert.strictEqual(err.errno, 'ENOTFOUND');
307307

308-
assert.ok(result == undefined);
308+
assert.strictEqual(result, undefined);
309309

310310
done();
311311
});
@@ -317,9 +317,9 @@ TEST(function test_resolveCname_failure(done) {
317317
TEST(function test_resolveTxt(done) {
318318
var req = dns.resolveTxt('google.com', function(err, records) {
319319
if (err) throw err;
320-
assert.equal(records.length, 1);
320+
assert.strictEqual(records.length, 1);
321321
assert.ok(util.isArray(records[0]));
322-
assert.equal(records[0][0].indexOf('v=spf1'), 0);
322+
assert.strictEqual(records[0][0].indexOf('v=spf1'), 0);
323323
done();
324324
});
325325

@@ -331,7 +331,7 @@ TEST(function test_resolveTxt_failure(done) {
331331
assert.ok(err instanceof Error);
332332
assert.strictEqual(err.errno, 'ENOTFOUND');
333333

334-
assert.ok(result == undefined);
334+
assert.strictEqual(result, undefined);
335335

336336
done();
337337
});
@@ -404,9 +404,9 @@ TEST(function test_lookup_all_mixed(done) {
404404

405405
ips.forEach(function(ip) {
406406
if (isIPv4(ip.address))
407-
assert.equal(ip.family, 4);
407+
assert.strictEqual(ip.family, 4);
408408
else if (isIPv6(ip.address))
409-
assert.equal(ip.family, 6);
409+
assert.strictEqual(ip.family, 6);
410410
else
411411
assert(false);
412412
});
@@ -495,13 +495,13 @@ req.oncomplete = function(err, domains) {
495495
console.log('nodejs.org = ', domains);
496496
assert.ok(Array.isArray(domains));
497497
assert.ok(domains.length >= 1);
498-
assert.ok(typeof domains[0] == 'string');
498+
assert.strictEqual(typeof domains[0], 'string');
499499
getaddrinfoCallbackCalled = true;
500500
};
501501

502502
process.on('exit', function() {
503503
console.log(completed + ' tests completed');
504-
assert.equal(running, false);
504+
assert.strictEqual(running, false);
505505
assert.strictEqual(expected, completed);
506506
assert.ok(getaddrinfoCallbackCalled);
507507
});

0 commit comments

Comments
 (0)