Skip to content
Permalink
Browse files

build: add check for empty openssl-fips flag

Currently, when specifying the --openssl-fips flag without any path
, or an empty path, does not generate an error. If a path is specified
then the following error is generated:

ERROR: FIPS is not supported in this version of Node.js

This commit adds a check so that the error is generated even if the
path is empty.

PR-URL: #25391
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information...
danbev authored and addaleax committed Jan 8, 2019
1 parent fe9b6ee commit 07ffa3f1897cf1aa365a6cc1524f77e54e73df14
Showing with 1 addition and 1 deletion.
  1. +1 −1 configure.py
@@ -1238,7 +1238,7 @@ def without_ssl_error(option):
if options.openssl_no_asm and options.shared_openssl:
error('--openssl-no-asm is incompatible with --shared-openssl')

if options.openssl_fips:
if options.openssl_fips or options.openssl_fips == '':
error('FIPS is not supported in this version of Node.js')

configure_library('openssl', o)

0 comments on commit 07ffa3f

Please sign in to comment.
You can’t perform that action at this time.