Skip to content
Permalink
Browse files

report: remove unnecessary return in setters

Barring shenanigans like Object.getOwnPropertyDescriptor(), return
values from a setter function will always be inaccessible. Remove
the `return` statements as they can be misleading, suggesting that the
return value is accessible and perhaps used somewhere.

PR-URL: #26614
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Trott authored and targos committed Mar 12, 2019
1 parent 3b471db commit 1b4553401c396b0963b656b5107c3edcae8ecdab
Showing with 5 additions and 5 deletions.
  1. +5 −5 lib/internal/process/report.js
@@ -34,14 +34,14 @@ const report = {
},
set directory(dir) {
validateString(dir, 'directory');
return nr.setDirectory(dir);
nr.setDirectory(dir);
},
get filename() {
return nr.getFilename();
},
set filename(name) {
validateString(name, 'filename');
return nr.setFilename(name);
nr.setFilename(name);
},
get signal() {
return nr.getSignal();
@@ -51,7 +51,7 @@ const report = {
convertToValidSignal(sig); // Validate that the signal is recognized.
removeSignalHandler();
addSignalHandler(sig);
return nr.setSignal(sig);
nr.setSignal(sig);
},
get reportOnFatalError() {
return nr.shouldReportOnFatalError();
@@ -60,7 +60,7 @@ const report = {
if (typeof trigger !== 'boolean')
throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger);

return nr.setReportOnFatalError(trigger);
nr.setReportOnFatalError(trigger);
},
get reportOnSignal() {
return nr.shouldReportOnSignal();
@@ -80,7 +80,7 @@ const report = {
if (typeof trigger !== 'boolean')
throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger);

return nr.setReportOnUncaughtException(trigger);
nr.setReportOnUncaughtException(trigger);
}
};

0 comments on commit 1b45534

Please sign in to comment.
You can’t perform that action at this time.