Skip to content

Commit 1daf517

Browse files
Trotttargos
Trott
authored and
targos
committed
test: fix inspector tests
The inspector tests should not be in the parallel directory as they likely all (or certainly almost all) use static ports, so port collisions will happen. This moves them all to sequential. We can move them back on a case-by-case basis. They were run sequentially when they were in the inspector directory which they were only moved from very recently. PR-URL: #16281 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
1 parent 1fe5308 commit 1daf517

24 files changed

+4
-4
lines changed

‎test/parallel/parallel.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ prefix parallel
77
[true] # This section applies to all platforms
88

99
[$system==win32]
10-
test-inspector-bindings : PASS, FLAKY
11-
test-inspector-debug-end : PASS, FLAKY
12-
test-inspector-stop-profile-after-done: PASS, FLAKY
1310

1411
[$system==linux]
1512

@@ -23,4 +20,3 @@ test-npm-install: PASS,FLAKY
2320
[$system==freebsd]
2421

2522
[$system==aix]
26-
test-inspector-stop-profile-after-done: PASS, FLAKY

‎test/sequential/sequential.status

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ prefix sequential
77
[true] # This section applies to all platforms
88

99
[$system==win32]
10+
test-inspector-bindings : PASS, FLAKY
11+
test-inspector-debug-end : PASS, FLAKY
12+
test-inspector-stop-profile-after-done: PASS, FLAKY
1013

1114
[$system==linux]
1215

@@ -17,3 +20,4 @@ prefix sequential
1720
[$system==freebsd]
1821

1922
[$system==aix]
23+
test-inspector-stop-profile-after-done: PASS, FLAKY

‎test/parallel/test-inspector-async-hook-setup-at-inspect-brk.js renamed to ‎test/sequential/test-inspector-async-hook-setup-at-inspect-brk.js

File renamed without changes.

‎test/parallel/test-inspector-async-hook-setup-at-signal.js renamed to ‎test/sequential/test-inspector-async-hook-setup-at-signal.js

File renamed without changes.

‎test/parallel/test-inspector-async-hook-teardown-at-debug-end.js renamed to ‎test/sequential/test-inspector-async-hook-teardown-at-debug-end.js

File renamed without changes.

‎test/parallel/test-inspector-async-stack-traces-promise-then.js renamed to ‎test/sequential/test-inspector-async-stack-traces-promise-then.js

File renamed without changes.

‎test/parallel/test-inspector-async-stack-traces-set-interval.js renamed to ‎test/sequential/test-inspector-async-stack-traces-set-interval.js

File renamed without changes.

‎test/parallel/test-inspector-bindings.js renamed to ‎test/sequential/test-inspector-bindings.js

File renamed without changes.

‎test/parallel/test-inspector-break-e.js renamed to ‎test/sequential/test-inspector-break-e.js

File renamed without changes.

‎test/parallel/test-inspector-break-when-eval.js renamed to ‎test/sequential/test-inspector-break-when-eval.js

File renamed without changes.

0 commit comments

Comments
 (0)