Skip to content

Commit 1fe5308

Browse files
maclover7targos
authored andcommitted
test: move inspector tests to parallel/sequential
* remove inspector directory artifacts PR-URL: #16197 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent cef125b commit 1fe5308

31 files changed

+23
-45
lines changed

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -409,9 +409,6 @@ test-pummel: all
409409
test-internet: all
410410
$(PYTHON) tools/test.py internet
411411

412-
test-inspector: all
413-
$(PYTHON) tools/test.py inspector
414-
415412
test-node-inspect: $(NODE_EXE)
416413
USE_EMBEDDED_NODE_INSPECT=1 $(NODE) tools/test-npm-package \
417414
--install deps/node-inspect test

test/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ On how to run tests in this directory, see
1919
|es-module |Yes |Test ESM module loading.|
2020
|fixtures | |Test fixtures used in various tests throughout the test suite.|
2121
|gc |No |Tests for garbage collection related functionality.|
22-
|inspector |Yes |Tests for the V8 inspector integration.|
2322
|internet |No |Tests that make real outbound connections (mainly networking related modules). Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections.|
2423
|known_issues |Yes |Tests reproducing known issues within the system. All tests inside of this directory are expected to fail consistently. If a test doesn't fail on certain platforms, those should be skipped via `known_issues.status`.|
2524
|message |Yes |Tests for messages that are output for various conditions (```console.log```, error messages etc.)|
File renamed without changes.

test/inspector/inspector.status

Lines changed: 0 additions & 16 deletions
This file was deleted.

test/inspector/testcfg.py

Lines changed: 0 additions & 6 deletions
This file was deleted.

test/parallel/parallel.status

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ prefix parallel
77
[true] # This section applies to all platforms
88

99
[$system==win32]
10+
test-inspector-bindings : PASS, FLAKY
11+
test-inspector-debug-end : PASS, FLAKY
12+
test-inspector-stop-profile-after-done: PASS, FLAKY
1013

1114
[$system==linux]
1215

@@ -19,3 +22,5 @@ test-npm-install: PASS,FLAKY
1922

2023
[$system==freebsd]
2124

25+
[$system==aix]
26+
test-inspector-stop-profile-after-done: PASS, FLAKY

test/inspector/test-async-hook-setup-at-inspect.js renamed to test/parallel/test-inspect-async-hook-setup-at-inspect.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const common = require('../common');
33
common.skipIfInspectorDisabled();
44
common.skipIf32Bits();
55
common.crashOnUnhandledRejection();
6-
const { NodeInstance } = require('../inspector/inspector-helper.js');
6+
const { NodeInstance } = require('../common/inspector-helper.js');
77
const assert = require('assert');
88

99
// Even with --inspect, the default async call stack depth is 0. We need a

test/inspector/test-async-hook-setup-at-inspect-brk.js renamed to test/parallel/test-inspector-async-hook-setup-at-inspect-brk.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const common = require('../common');
33
common.skipIfInspectorDisabled();
44
common.skipIf32Bits();
55
common.crashOnUnhandledRejection();
6-
const { NodeInstance } = require('./inspector-helper.js');
6+
const { NodeInstance } = require('../common/inspector-helper.js');
77
const assert = require('assert');
88

99
const script = `

test/inspector/test-async-hook-setup-at-signal.js renamed to test/parallel/test-inspector-async-hook-setup-at-signal.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const common = require('../common');
33
common.skipIfInspectorDisabled();
44
common.skipIf32Bits();
55
common.crashOnUnhandledRejection();
6-
const { NodeInstance } = require('../inspector/inspector-helper.js');
6+
const { NodeInstance } = require('../common/inspector-helper.js');
77
const assert = require('assert');
88

99
const script = `

0 commit comments

Comments
 (0)